Font Library: Add font collection JSON schema #57736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasbenedetto
added
the
[Feature] Typography
|
Just a question - What is the font collection JSON schema used for? The README mentions the following:
In the future, does this mean that users will be able to define JSON for font collections in a JSON file separate from theme.json? |
This JSON schema is used as any other schema defining a JSON structure. It's a useful tool and reference for extenders creating font collections.
Extenders can create and register font collections. A Font Collection is a list of fonts available to the user to be installed. Example: Google fonts is registered as a font collection. Extenders can register one or more collections to provide the users with more font options ready to be installed. |
matiasbenedetto
added
the
[Type] Developer Documentation
matiasbenedetto
requested review from
ntwb,
nerrad and
ajitbohra
as code owners
|
Size Change: +2.51 kB (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
jffng
approved these changes
Jan 11, 2024
Co-authored-by: Jeff Ong <[email protected]>
jffng
reviewed
Jan 11, 2024
Co-authored-by: Jeff Ong <[email protected]>
Co-authored-by: Jeff Ong <[email protected]>
Co-authored-by: Jeff Ong <[email protected]>
This was referenced Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
gen-theme-reference.jsability to resolve a definition by name.Why?
As a reference for the data JSON files for font collections.
How?
Creating a new schema and reusing part of the existent theme.json schema
Testing instructions
Create a file and reference the
font-collection.jsonschema like this:If you use an editor like VS Code, you should have autocomplete and error detection working.
Disclaimer: Instead of this long URL, after merging into trunk, we will be able to use:
https://schemas.wp.org/trunk/font-collection.jsonFull
font-collection.jsonexample:{ "$schema": "https://raw.githubusercontent.com/WordPress/gutenberg/1e4e1406d303b41e37b27e69cfbc654f42d6a589/schemas/json/font-collection.json", "version": 1, "categories": [ { "slug": "serif", "name": "Serif", } ], "font_families": [ { "categories": [ "serif" ], "font_family_settings":{ "fontFamily": "Piazzolla, Times, Serif", "name": "Piazzolla", "slug": "piazzolla", "fontFace": [ { "fontFamily": "Piazzolla", "src": "http://example.com/fonts/piazzolla400.ttf", "fontWeight": 400, "fontStyle": "normal" } ] } } ] }Closes: #55266