Add compact size variant to InputControl-based components
#57398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Enhancement
ciampo
approved these changes
Jan 2, 2024
Comment on lines
-33
to
-52
| const fontSizeStyles = ( { selectSize = 'default' }: SelectProps ) => { | ||
| const sizes = { | ||
| default: '13px', | ||
| small: '11px', | ||
| '__unstable-large': '13px', | ||
| }; | ||
|
|
||
| const fontSize = sizes[ selectSize ]; | ||
| const fontSizeMobile = '16px'; | ||
|
|
||
| if ( ! fontSize ) return ''; | ||
|
|
||
| return css` | ||
| font-size: ${ fontSizeMobile }; | ||
|
|
||
| @media ( min-width: 600px ) { | ||
| font-size: ${ fontSize }; | ||
| } | ||
| `; | ||
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #46734
Prerequisite for #56388
What?
Adds an explicit
compactsize variant to InputControl and all the components based on those styles. This variant has 32px height, in line with the new sizing scheme.Affected components
Why?
We will sometimes need a compact variant for a smaller footprint.
How?
This size variant is actually identical with the current
defaultsize variants. Since they will eventually be superseded by the new 40px default, we need to keep an explicitcompactvariant.Testing Instructions
See the Storybook stories for the affected components.