Migrate remaining 'block switcher' e2e tests to Playwright #57381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
the
[Type] Automated Testing
Mamaduka
requested review from
kevin940726,
ntwb,
nerrad and
ajitbohra
as code owners
Mamaduka
requested review from
WunderBart and
t-hamano
and removed request for
ntwb,
ajitbohra and
nerrad
Mamaduka
commented
Dec 26, 2023
| await page.keyboard.type( '## I am a header' ); | ||
| await page.keyboard.down( 'Shift' ); | ||
| await page.keyboard.press( 'ArrowUp' ); | ||
| await page.keyboard.up( 'Shift' ); |
There was a problem hiding this comment.
Note for future me: If this fails again, ensure the block toolbar is displayed by adding await pageUtils.pressKeys( 'alt+F10' );.
Currently, I can reproduce the scenario with Playwright, but I can do it manually sometimes.
|
Size Change: +159 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
LGTM 👍
Although I suggested a small change, I ran this test in debug mode and confirmed that the test worked correctly.
BTW I learned that this test migration was also attempted in #50845. How about adding him as a co-author?
| await createNewPost(); | ||
| } ); | ||
|
|
||
| it( 'Should show the expected block transforms on the list block when the blocks are removed', async () => { |
There was a problem hiding this comment.
How about making "Should" a lower case along with other tests?
There was a problem hiding this comment.
I think it's okay. We don't really have a strict guideline when it comes to naming.
| .getByRole( 'menuitem', { name: 'Columns' } ) | ||
| ).toBeHidden(); | ||
| } ); | ||
|
|
||
| test( 'Block variation transforms', async ( { editor, page } ) => { | ||
| // This is the `stack` Group variation. |
There was a problem hiding this comment.
Suggested change
| // This is the `stack` Group variation. | |
| // This is the `flex` Group variation. |
This looks like a typo.
There was a problem hiding this comment.
I don't think so; the variation name is stack. The flex is just implementation details.
Co-authored-by: Pavan Patil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
PR migrates
block-switcher.test.jse2e tests to Playwright.Why?
The test has been failing a lot recently. Ref: #40369.
Testing Instructions