Interactivity: Use domReady package over DOMContentLoaded #56986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +66 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in dfbd3ab. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7194817409
|
sirreal
force-pushed
the
fix/interactivity-api-domready
branch
from
dfbd3ab
to
8c12683
Compare
|
Very strange, this seems to break interactivity-based navigation. At least on the playground. I'll need to debug more. |
sirreal
added a commit
that referenced
this pull request
Jan 5, 2024
…ivity (#57602) Use an explicit module external type by default for the @wordpress/interactivity external module. In #57577, we switched the default external type from module (externals are always hoisted to static imports) to import (externals are always dynamic import()s). That's likely desirable for most external modules, but @wordpress/interactivity has some known issues where it may not behave as expected if it's not initialized before DOMContentLoaded (#56986). By declaring an explicit module external type for @wordpress/interactivity, webpack will always hoist this import to a static import, preventing issues with dynamic imports of the package.
gziolo
added
[Feature] Interactivity API
|
Superseded by #62734 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Use the
dom-readypackage for Interactivity API initialization.Why?
If the interactivity script is loaded after
DOMContentLoaded(this is easy to trigger as an async import inside another<script type=module>tag), the interactivity API is never initialized.How?
By using the
dom-readypackage, we ensure that initialization happens regardless of when the script is loaded.Testing Instructions