Fix errant scrollbar when zoomed out mode is activated #56771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
Size Change: +14 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When activating zoomed out mode, the editor canvas scroll bar can still be displayed which results in a double scrollbar (zoomed out mode has its own scrollbar).
Why?
Users don't need that many scrollbars.
How?
Adds an
overflow: hiddenstyle to the editor canvas body, only when zoomed out mode is active.Also removes a stray
}in the style declarations.Testing Instructions
Note: It's easier to see the scrollbar when the Mac OS setting "Scrollbars always on" is active.
wp-admin/admin.php?page=gutenberg-experimentspage.Expected: The canvas shouldn't have a scrollbar
On trunk: At some viewport sizes the canvas has a scrolllbar
Screenshots or screencast
Before
After