Fix order of typography sizes and families #56659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlende
added
[Type] Bug
|
Size Change: -137 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Having the order different caused some confusion in #52200 of which values are present.
This fixes the order to be the same in all places for the typography panel.
Why?
Bug fix
How?
mergeOriginsfunction to concatenate them.concatif we only need to checklength > 0.mergeOriginsfunction caches results for subsequent calls.Testing Instructions
Ensure that the order is the same in all three places.
Do the same for … > Typography > FontFamilies
Testing Instructions for Keyboard
N/A
Screenshots or screencast
Before
After