Move document tools motion to header-edit-mode layout level #55904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving the motion up to the layout level for the header keeps the navigation document tools and the animation of it separated for a cleaner implementation.
|
Size Change: -30 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 142272a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6773814136
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed in #55678 by @t-hamano. Thanks for the research and fix!
What?
Moving the motion div up to the layout level for the edit site header keeps the navigation document tools and the animation of it separated. Now all the animations are in the edit-site-header rather than being passed into the document tools navigation.
Why?
Fewer props passed. Animation of header logic stays in one file, so it's easier to reason about. The navigation has no need to know about how it's animated.
How?
Move the animation div up a level.
Testing Instructions
Open the site editor.
Click on the editor pane.
Check there are no console errors.
Header animation should match
trunk