Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try Ariakit Select for new CustomSelectControl component #55790

Merged
merged 36 commits into from
Nov 23, 2023
Merged

Try Ariakit Select for new CustomSelectControl component #55790

merged 36 commits into from
Nov 23, 2023

Commits on Nov 10, 2023

  1. Create base component using ariakit

    @brookewp
    brookewp committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    d3573ae View commit details
    Browse the repository at this point in the history

  2. Simplify story example

    @brookewp
    brookewp committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    9d34f51 View commit details
    Browse the repository at this point in the history

  3. Add options for children and value with stories

    @brookewp
    brookewp committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    9000c5a View commit details
    Browse the repository at this point in the history

  4. Update types

    @brookewp
    brookewp committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    0024d32 View commit details
    Browse the repository at this point in the history

  5. Add uncontrolled story and adapt value

    @brookewp
    brookewp committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    bc0683f View commit details
    Browse the repository at this point in the history

  6. Remove duplicate import

    @brookewp
    brookewp committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    2a3c220 View commit details
    Browse the repository at this point in the history

  7. Add size prop

    @brookewp
    brookewp committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    2b9174d View commit details
    Browse the repository at this point in the history

  8. Changes from pairing session with ciampo

    @brookewp
    brookewp committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    63267af View commit details
    Browse the repository at this point in the history

  9. Rename and cleanup

    @brookewp
    brookewp committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    017bd82 View commit details
    Browse the repository at this point in the history

  10. Update styles

    @brookewp
    brookewp committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    c6cffa6 View commit details
    Browse the repository at this point in the history

  11. Add context

    @brookewp
    brookewp committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    27b9854 View commit details
    Browse the repository at this point in the history

  12. Add README

    @brookewp
    brookewp committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    add8e6d View commit details
    Browse the repository at this point in the history

  13. Update manifest

    @brookewp
    brookewp committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    d343165 View commit details
    Browse the repository at this point in the history

  14. Update types and move context provider

    @brookewp
    brookewp committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    3edc792 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Add back types for multi-selection

    @brookewp
    brookewp committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    7ef27ea View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Remove file for moved component

    @brookewp
    brookewp committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    d35a044 View commit details
    Browse the repository at this point in the history

  2. Add translation for placeholder

    @brookewp
    brookewp committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    ede0ef9 View commit details
    Browse the repository at this point in the history

  3. Add check and cleanup styles

    @brookewp
    brookewp committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    c3e4d29 View commit details
    Browse the repository at this point in the history

  4. Add multiselect example

    @brookewp
    brookewp committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    f771fad View commit details
    Browse the repository at this point in the history

  5. Require type children for CustomSelectItem

    @brookewp
    brookewp committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    3b5f968 View commit details
    Browse the repository at this point in the history

  6. Add small size and update sizing logic

    @brookewp
    brookewp committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    e2ee037 View commit details
    Browse the repository at this point in the history

  7. Update stories with ciampo’s suggested changes

    @brookewp
    brookewp committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    b7b2fff View commit details
    Browse the repository at this point in the history

  8. Update styles to match legacy CustomSelectControl

    @brookewp
    brookewp committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    e68ea07 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2023

  1. Cleanup based on PR feedback

    @brookewp
    brookewp committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    27fc5fd View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Children as optional

    @brookewp
    brookewp committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    24e08ad View commit details
    Browse the repository at this point in the history

  2. Incorporate ciampo’s suggestions to refine styles

    @brookewp
    brookewp committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    f866d36 View commit details
    Browse the repository at this point in the history

  3. Make value required for CustomSelectItem and fix naming in comment

    @brookewp
    brookewp committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    ceb6b45 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'trunk' into try/customselect-ariakit

    @brookewp
    brookewp committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    23c0f91 View commit details
    Browse the repository at this point in the history

  5. Update changelog

    @brookewp
    brookewp committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    0b8250a View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Refine styles and add styling to active item

    @brookewp
    brookewp committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    c29569a View commit details
    Browse the repository at this point in the history

  2. Only render label if defined

    @brookewp
    brookewp committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    39b7650 View commit details
    Browse the repository at this point in the history

  3. Cleanup story

    @brookewp
    brookewp committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    ff02e44 View commit details
    Browse the repository at this point in the history

  4. Add suggestions to WIP README and types

    @brookewp
    brookewp committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    b975f51 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Make label required

    @brookewp
    brookewp committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    04faa3f View commit details
    Browse the repository at this point in the history

  2. Improve logic for default rendered value

    @brookewp
    brookewp committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    df54fe8 View commit details
    Browse the repository at this point in the history

  3. Update stories

    @brookewp
    brookewp committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    45689ab View commit details
    Browse the repository at this point in the history