[Data views]: Normalize render fields function
#55411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Code Quality
ntsekouras
commented
Oct 17, 2023
| @@ -132,18 +132,12 @@ function ViewList( { | |||
| paginationInfo, | |||
| } ) { | |||
| const columns = useMemo( () => { | |||
| const _columns = [ | |||
| ...fields.map( ( field ) => { | |||
There was a problem hiding this comment.
There was an extra spreading of the array here.
ntsekouras
force-pushed
the
update/normalize-fields-render-function
branch
from
f86f4d5
to
ba56611
Compare
|
Size Change: +39 B (0%) Total Size: 1.66 MB
ℹ️ View Unchanged
|
mcsf
approved these changes
Oct 17, 2023
Co-authored-by: Miguel Fonseca <[email protected]>
youknowriad
reviewed
Oct 17, 2023
| @@ -89,7 +89,7 @@ export default function PagePages() { | |||
| id: 'featured-image', | |||
| header: __( 'Featured Image' ), | |||
| accessorFn: ( page ) => page.featured_media, | |||
| render: ( { item, view: currentView } ) => | |||
| render: ( item, currentView ) => | |||
There was a problem hiding this comment.
The problem is that this is not a component anymore, I think make it a component have some advantages. So I'd rather change the signature of accessorFn. In fact I'd rename accessorFn to something like getValue or something. accessorFn is too tanstaky and too confusing to me.
There was a problem hiding this comment.
Yeah, I'm planning on doing this today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #55083
This PR normalizes the
renderfields function to have similar signature, in order for views to call just one function. I haven't yet removedaccessorFnsince it's used in tanstack(list view) and we have to investigate more before doing so.Testing Instructions