Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backgroundImage to the theme json docs for appearanceTools #55376

Merged

Conversation

andrewserong
Copy link
Contributor

What?

Part of #54336

Update the theme JSON docs to mention background: backgroundImage under appearanceTools.

Why?

Over in #53934, I'd updated the theme-json-living.md file, but forgot there was another place to describe the properties opted-into by appearanceTools.

How?

Just add a line to the docs.

Testing Instructions

Proofread for typos and accuracy 😄

Testing Instructions for Keyboard

Screenshots or screencast

Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewserong
Copy link
Contributor Author

Thanks for the quick review!

@andrewserong andrewserong merged commit d339baf into trunk Oct 16, 2023
59 checks passed
@andrewserong andrewserong deleted the update/theme-json-docs-to-mention-background-image branch October 16, 2023 03:56
@github-actions github-actions bot added this to the Gutenberg 16.9 milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants