Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Tabs in editor settings #55360

Merged
merged 23 commits into from
Dec 12, 2023
Merged

Implement Tabs in editor settings #55360

merged 23 commits into from
Dec 12, 2023

Commits on Dec 8, 2023

  1. implement Tabs in editor settings sidebar

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    ad8819d View commit details
    Browse the repository at this point in the history

  2. remove duplicated styles from editor sidebar

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    4cb5c69 View commit details
    Browse the repository at this point in the history

  3. incorporate initial feedback

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    ddd8d7f View commit details
    Browse the repository at this point in the history

  4. pass props to Tabs directly

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    4142f5a View commit details
    Browse the repository at this point in the history

  5. add closeGeneralSidebar to onSelect callback

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    b67019b View commit details
    Browse the repository at this point in the history

  6. set TabPanels to focuasable={false}

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    b9723d7 View commit details
    Browse the repository at this point in the history

  7. detect when sidebar is closed. pass selectedTabId of null

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    1fbbef4 View commit details
    Browse the repository at this point in the history

  8. improve Tabs onSelect callback

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    f3fea72 View commit details
    Browse the repository at this point in the history

  9. remove aria-label and data-label props

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    a01b24c View commit details
    Browse the repository at this point in the history

  10. add note explaining null selected tab when sidebar is closed

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    2e73939 View commit details
    Browse the repository at this point in the history

  11. update e2e test

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    ed1c930 View commit details
    Browse the repository at this point in the history

  12. style updates

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    4d47b34 View commit details
    Browse the repository at this point in the history

  13. update internal component structure to avoid rerenders

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    1e471ee View commit details
    Browse the repository at this point in the history

  14. remove fragment

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    9ea4a0e View commit details
    Browse the repository at this point in the history

  15. prevent infinite loop when opening third party sidebar

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    8e5ad95 View commit details
    Browse the repository at this point in the history

  16. update e2e tests for Tabs compatibility

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    e57f8a1 View commit details
    Browse the repository at this point in the history

  17. fix double top margin on tabpanels

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    8a7b8f1 View commit details
    Browse the repository at this point in the history

  18. update to use new tabId prop

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    c3eb43e View commit details
    Browse the repository at this point in the history

  19. remove import that is no longer needed after rebase

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    73db1df View commit details
    Browse the repository at this point in the history

  20. fix keyboard navigable blocks test

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    7fe4d02 View commit details
    Browse the repository at this point in the history

  21. fix visibility and tab order tests

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    4d0c547 View commit details
    Browse the repository at this point in the history

  22. fix footnotes tests

    @chad1008
    chad1008 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    10507a2 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. fix change detection test

    @chad1008
    chad1008 committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    5d20c8b View commit details
    Browse the repository at this point in the history