Cover: Fix media type check in the onSelectMedia hook #55168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WunderBart
added
the
[Block] Cover
WunderBart
requested review from
Mamaduka,
glendaviesnz,
kevin940726 and
costdev
|
Size Change: +26 B (0%) Total Size: 1.65 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 659ba57. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6459760901
|
talldan
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Thanks for hunting this issue down @WunderBart! Glad to see the end to end tests are somewhat working.
I followed the testing instructions. Against trunk I can see the bug clearly, and it's also more obvious when you compare what happens when adding an existing media library image vs uploading.
On this PR, everything is resolved.
Code looks good and makes sense to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #55086
Fix a bug where when setting an initial image to the Cover block, the overlay color is always set to
#FFFwhen it should be an average color of the uploaded image.Related discussion: https://wordpress.slack.com/archives/C02QB2JS7/p1696833027605459
How?
The
onSelectMediahandler is called twice:url(blob) andtypefields. Thetypefield isimageso the average background color is calculated and applied. However, this is only visible for a split second, becausetypefield's value is nowattachment. Because the average background color is being calculated only for images, it is now failing and the color is reset to the default value.To address this inconsistency, I've modified the condition to also check the
media_typefield in the uploaded media data. This seems to rectify the problem.Testing Instructions
trunk