Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picked commits for WordPress 6.4 Beta 2 #54914

Merged
merged 37 commits into from
Oct 2, 2023
Merged

Commits on Sep 28, 2023

  1. Configuration menu
    Copy the full SHA
    cd9fc99 View commit details
    Browse the repository at this point in the history
  2. Fix set upload dir test (#54762)

    matiasbenedetto authored and mikachan committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    3ada010 View commit details
    Browse the repository at this point in the history
  3. Site Editor: Prevent unintended actions on the classic theme (#54422)

    * Add action and selector to track access to Patterns page
    
    * Add a URL parameter to check if the Patterns page was accessed directly
    
    * Revert lib changes
    
    * Fix critical error in the Post Editor
    
    * Explicitly add `! isBlockBasedTheme` with `isTemplatePartsMode`
    
    * Fix critical error in the Post Editor
    t-hamano authored and mikachan committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    121a1be View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    592aed1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d4583eb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0de93a9 View commit details
    Browse the repository at this point in the history
  7. Performance Tests: Separate page setup from test (#53808)

    # Conflicts:
    #	test/performance/specs/post-editor.spec.js
    WunderBart authored and mikachan committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    8351350 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bcd11e4 View commit details
    Browse the repository at this point in the history
  9. Paragraph: Make 'aria-label' consistent with other blocks (#54687)

    * Paragraph: Make 'aria-label' consistent with other blocks
    
    * Update tests
    
    * Try using BC labels in performance tests
    Mamaduka authored and mikachan committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    ff67ea7 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. Configuration menu
    Copy the full SHA
    9dea2a3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c20f4a1 View commit details
    Browse the repository at this point in the history
  3. Font Library: avoid deprected error in test (#54802)

    * fix deprecated call
    
    * removing unwanted line
    matiasbenedetto authored and mikachan committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    87c2691 View commit details
    Browse the repository at this point in the history
  4. Fix the ShortcutProvider usage (#54851)

    Co-authored-by: Marin Atanasov <[email protected]>
    2 people authored and mikachan committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    1271ebb View commit details
    Browse the repository at this point in the history
  5. Image: Ensure false values are preserved in memory when defined in …

    …`theme.json` (#54639)
    
    * Modify conditional when parsing config
    
    * Only drop the value if it's undefined.
    
    ---------
    
    Co-authored-by: Michal Czaplinski <[email protected]>
    2 people authored and mikachan committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    1ad31d0 View commit details
    Browse the repository at this point in the history
  6. Use "Not synced" in place of "Standard" nomenclature for patterns (#5…

    …4839)
    
    * Standard -> Not synced
    
    * Fix broken test
    
    ---------
    
    Co-authored-by: Glen Davies <[email protected]>
    2 people authored and mikachan committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    1b53e1b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    949b28c View commit details
    Browse the repository at this point in the history
  8. Move mime-type collection generation to a function that can be tested… (

    #54844)
    
    * Move mime-type collection generation to a function that can be tested.  Refactored to use that function.
    
    * linting changes
    
    * Add unit tests to mime type getter
    
    * Fixed linting errors
    
    * test the entire output array and replace assertTrue by assertEquals
    
    * fixing docs
    
    ---------
    
    Co-authored-by: Matias Benedetto <[email protected]>
    2 people authored and mikachan committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    23ad86f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    78d3141 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3375dbc View commit details
    Browse the repository at this point in the history
  11. Footnotes: Add aria-label to return links (#54843)

    * Add aria-label to footnotes front-end links.
    
    * Add visual output. Fix PHPCS errors.
    
    * Remove visual changes, fix in follow-up.
    alexstine authored and mikachan committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    9949351 View commit details
    Browse the repository at this point in the history
  12. Font Library: Changed the OTF mime type expected value to be what PHP…

    … returns (#54886)
    
    * Changed the OTF mime type expected value to be what PHP returns
    
    * add unit test for otf file installation
    
    ---------
    
    Co-authored-by: madhusudhand <[email protected]>
    2 people authored and mikachan committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    83cb042 View commit details
    Browse the repository at this point in the history
  13. Image: Fix layout shift when lightbox is opened and closed (#53026)

    * Replace overflow: hidden with JavaScript callback to prevent scrolling
    
    * Disable scroll callback on mobile; add comments; fix scrim styles
    
    The page jumps around when trying to override the scroll behavior
    on mobile, so I disabled it altogether. I've also added comments
    to clarify this and other decisions made around the scroll handling.
    
    While testing, I realized that the scrim was completely opaque during
    the zoom animation, which does not match the design, so I added a new
    animation specifically for the scrim to fix that.
    
    * Add handling for horizontally oriented pages
    
    * Move close button so that it's further from scrollbar on desktop
    
    * Fix call to handleScroll() and add touch callback to new render method
    
    * Improve lightbox experience on mobile
    
    To ensure pinch to zoom works as expected when the lightbox
    is open on mobile, I added logic to disable the scroll override
    when touch is detected. Without this, the scroll override kicks
    in whenever one tries to pinch to zoom, and it breaks the experience.
    
    I also revised the styles for the scrim to make it opaque, as having
    content visible outside of the lightbox is distracting when
    pinching to zoom on a mobile device, and I think having a consistent
    lightbox across devices will make for the best user experience.
    
    * Fix spacing
    
    * Add touch directives to block supports
    
    * Fix spacing in block supports
    
    * Rename attribute for clarity
    
    * Update comment
    
    * Update comments
    
    * Fix spacing
    
    ---------
    
    Co-authored-by: Ricardo Artemio Morales <[email protected]>
    2 people authored and mikachan committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    0d63803 View commit details
    Browse the repository at this point in the history
  14. Font Library: move font uploads to a new tab (#54655)

    * move font uploads to a new tab in the modal
    
    * fix invalid success message and revert the dropzone to modal
    
    * add success notice for font uploads
    
    * make supported file formats message dynamic based on allowed extensions
    
    * update hint text and clear successful message with a fresh upload
    madhusudhand authored and mikachan committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    75cb40f View commit details
    Browse the repository at this point in the history
  15. Block custom CSS: Fix incorrect CSS when multiple root selectors (#53602

    )
    
    * Block custom CSS: Fix incorrect CSS when multiple root selectors
    
    * Fix PHP lint error
    
    * Use `scope_selector` and `append_to_selector` method and update unit test
    
    * Use `scopeSelector` and `appendToSelector` function and update JS unit test
    
    * Update packages/block-editor/src/components/global-styles/test/use-global-styles-output.js
    
    Co-authored-by: Aaron Robertshaw <[email protected]>
    
    * Update packages/block-editor/src/components/global-styles/test/use-global-styles-output.js
    
    Co-authored-by: Aaron Robertshaw <[email protected]>
    
    * Update packages/block-editor/src/components/global-styles/test/use-global-styles-output.js
    
    Co-authored-by: Aaron Robertshaw <[email protected]>
    
    * Update packages/block-editor/src/components/global-styles/test/use-global-styles-output.js
    
    Co-authored-by: Aaron Robertshaw <[email protected]>
    
    * Update packages/block-editor/src/components/global-styles/utils.js
    
    Co-authored-by: Aaron Robertshaw <[email protected]>
    
    * re-trigger CI
    
    ---------
    
    Co-authored-by: Aaron Robertshaw <[email protected]>
    2 people authored and mikachan committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    c35b6d0 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    7b19836 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    458a73d View commit details
    Browse the repository at this point in the history
  18. Popover: Fix the styles for components that use emotion within popove…

    …rs (#54912)
    
    # Conflicts:
    #	packages/components/CHANGELOG.md
    youknowriad authored and mikachan committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    ccf7656 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Footnotes: use core’s meta revisioning if available (#52988)

    # Conflicts:
    #	packages/block-library/src/footnotes/index.php
    adamsilverstein authored and mikachan committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    507d0e9 View commit details
    Browse the repository at this point in the history
  2. Remove base url from link control search results (#54553)

    * Expose baseURL setting on Post and Site Editors via block settings
    
    * Strip baseURL from rendered search results
    
    * Only fetch baseURL once in top level component
    
    * Simplify implementation to utilise URL parse functions
    
    * Improve comment wording to avoid referencing undefined var
    
    * Remove superfluous conditional
    
    * Decode URL prior to operations
    
    * Refactor for readability
    
    * Fix where url is not defined
    
    * Revert change to filter util
    
    * Ensure that filterURLForDisplay always receives a string as an arg
    
    * Make e2e test locator less strict
    
    * Prefer pipe
    
    * Force remove trailing slash
    getdave authored and mikachan committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    7525413 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    614f768 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b5596e4 View commit details
    Browse the repository at this point in the history
  5. Site Editor: Avoid same key warnings in template parts area listings (#…

    …54863)
    
    * TemplateAreas use template part clientId as key
    * HomeTemplateDetails use template part clientId as key
    * Cleanup useSelect hook
    Mamaduka authored and mikachan committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    34fa64a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9836669 View commit details
    Browse the repository at this point in the history
  7. Font Library: refactor endpoint permissions (#54829)

    * break the checking of user permission and file write permissions
    
    * return error 500 if the request to the install fonts endpoint needs write permissions and wordpress doens't have write permission on the server
    
    * do not ask file write permission on uninstall endpoint
    
    * Standardize the output of install and uninstall fonts endpoints
    
    Co-authored-by: Jason Crist <[email protected]>
    Co-authored-by: Jeff Ong <[email protected]>
    
    * Handle standardized output from install and uninstall endpoints in the frontend
    
    Co-authored-by: Jason Crist <[email protected]>
    Co-authored-by: Jeff Ong <[email protected]>
    
    * Update the install and unintall fonts endpoints unit tests for the new standardized output format
    
    Co-authored-by: Jason Crist <[email protected]>
    Co-authored-by: Jeff Ong <[email protected]>
    
    * fix the refersh call for the library
    
    Co-authored-by: Jason Crist <[email protected]>
    Co-authored-by: Jeff Ong <[email protected]>
    
    ---------
    
    Co-authored-by: Jason Crist <[email protected]>
    Co-authored-by: Jeff Ong <[email protected]>
    3 people authored and mikachan committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    fd167db View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c4ffd4a View commit details
    Browse the repository at this point in the history
  9. Fix Search Block not updating in Nav block (#54823)

    * Avoid setState in render
    
    * Attempt at test coverage
    
    * Improve tests and make them work
    getdave authored and mikachan committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    3e6d894 View commit details
    Browse the repository at this point in the history
  10. Remove word-wrap property (#54866)

    getdave authored and mikachan committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    59fff9f View commit details
    Browse the repository at this point in the history