Block Editor: Expose getDuotoneFilter() as private API
#54905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Package] Block editor
tyxla
requested review from
Mamaduka,
youknowriad,
jsnajdr,
flootr and
andrewserong
|
Size Change: +9 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR exposes the
getDuotoneFilter()utility as a private API.Why?
It was previously exposed as
__unstablePresetDuotoneFilter, however since #52888 refactoredPresetDuotoneFiltertogetDuotoneFilter(), that was never exposed again.The
__unstablePresetDuotoneFilterwas used in external consumers of the@wordpress/block-editorpackage and ideally, we'd like to be able to port to the new version.How?
We're just adding
getDuotoneFilter()to the list of private APIs of the package.Testing Instructions
All checks should be green.
Testing Instructions for Keyboard
None.
Screenshots or screencast
None.