-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query block: Start prefetching on first click to next/previous #54781
Merged
luisherranz
merged 1 commit into
trunk
from
query-block-start-prefetching-on-first-click-to-next-previous
Sep 25, 2023
Merged
Query block: Start prefetching on first click to next/previous #54781
luisherranz
merged 1 commit into
trunk
from
query-block-start-prefetching-on-first-click-to-next-previous
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisherranz
added
[Type] Enhancement
A suggestion for improvement.
[Block] Query Loop
Affects the Query Loop Block
[Feature] Interactivity API
API to add frontend interactivity to blocks.
labels
Sep 25, 2023
luisherranz
added
the
Backport to Gutenberg RC
Pull request that needs to be backported to a Gutenberg release candidate (RC)
label
Sep 25, 2023
Size Change: +28 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
DAreRodz
reviewed
Sep 25, 2023
DAreRodz
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thanks, David 🙂 |
luisherranz
deleted the
query-block-start-prefetching-on-first-click-to-next-previous
branch
September 25, 2023 11:09
24 tasks
mikachan
pushed a commit
that referenced
this pull request
Sep 25, 2023
I just cherry-picked this PR to the release/16.7 branch to get it included in the next release: 7b6e996 |
mikachan
removed
the
Backport to Gutenberg RC
Pull request that needs to be backported to a Gutenberg release candidate (RC)
label
Sep 25, 2023
This was referenced Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Query Loop
Affects the Query Loop Block
[Feature] Interactivity API
API to add frontend interactivity to blocks.
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I added logic to start prefetching the next page on the first click to the next and previous buttons.
Why?
Because when the user starts to paginate, it's very likely that they will continue paginating. Prefetching the next/previous links automatically makes the subsequent pagination feel 100% instant.
How?
By adding an effect that triggers when the url changes and the user has paginated at least once.
Testing Instructions
Screenshots or screencast
Screen.Capture.on.2023-09-25.at.11-43-39.mp4