Edit Widgets: Fix invisible action area when the top toolbar is enabled #54329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +19 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
t-hamano
requested review from
talldan,
noisysocks,
adamziel,
kevin940726 and
ellatrix
as code owners
draganescu
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #53526
What?
This PR fixes a problem in the widget editor where the action area (pinned items) is not visible when the top toolbar is enabled.
Note: When you open the widget editor, you will notice that the layout of the widget area is broken. This issue was reported in #54295.
Why?
Like the Post Editor, the Widget Editor requires the width of the pinned items to be subtracted when calculating the width of the top toolbar.
How?
Added the pinned items selector (
.edit-widgets-header__actions) so that the width of the pinned items is taken into account when calculating the width of the top toolbar.At the same time, the padding on both ends of the header area (
.edit-widgets-header) has been moved to its child elements (.edit-widgets-header__navigable-toolbar-wrapper,.edit-widgets-header__actions) in order to accurately calculate the width of the top toolbar.Testing Instructions