Move the switch to enable new Font Library to Experiments setting #54315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tonya Mork <[email protected]>
This reverts commit 43dae16.
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/editor-settings.php ❔ lib/experiments-page.php ❔ lib/load.php |
|
Thanks for adding this, I have't checkout and test it yet but overall looks good and useful. Please rename the option to "Font Library" because "Font API" is another area of the code in charge of something else and soon it will be deprecated. |
|
Size Change: +8 B (0%) Total Size: 1.61 MB
ℹ️ View Unchanged
|
|
I have updated the names. |
matiasbenedetto
changed the title
vcanales
added
the
[Feature] Typography
There was a problem hiding this comment.
This is working great on my end. Thanks for working on this.
My only concern is this:
As far as I know, the Gutenberg experiments page is only available when you have Gutenberg plugins installed and activated. In consequence, this switch will be only available when using Gutenberg. At the same time, the Font Library feature is intended to be in WordPress core, so we won't be able to turn the feature on/off while using just core.
For those reasons, I'm not 100% sure that we should merge this. What do you think of an alternative like continuing to use the FONT_LIBRARY_ENABLE to switch the feature on/off in the backend and add a check in the frontend too as you made in:
Sure, that's reasonable. Do you think it would hurt anything to use the same interface to enable the feature via UI? I'm not sure what the timeline is expected to be for it being defaulted to ON; That may inform if its even worth having a UI way to do that... |
This is intended to be working by default on WordPress core 6.4 release. |
I'm not sure what interface you are referring to. |
|
Flaky tests detected in 4a6cfe9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6146872944
|
matiasbenedetto
requested review from
kevin940726,
Mamaduka and
nerrad
as code owners
|
Closing this PR as outdated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Moves the switch to turn on/off the Fonts API to the Gutenberg Experiments page.
Also disables the interface when disabled.