Theme Previews: Make the back button customizable #54242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Enhancement
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.4/theme-previews.php ❔ lib/load.php |
|
Size Change: +5.44 kB (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
This feels a little less complex than #54174 which adds a second customisation point in __experimentalThemePreviewBackLink. By having core filter __experimentalDashboardLink when previewing a theme and allowing plugins to re-filter that we reuse the original customisation point.
alexstine
reviewed
Sep 8, 2023
There was a problem hiding this comment.
@scruffian Are you also able to filter the link text? Changing the URL without changing the text sounds like the beginnings of an accessibility and UX nightmare. If you select "Back" and end up at https://wordpress.com, this link did something different than what a user would have expected it to do.
okmttdhr
reviewed
Sep 11, 2023
|
I changed it to make the backlink text customizable! |
okmttdhr
approved these changes
Sep 12, 2023
1 task
|
Flaky tests detected in 14c75ac. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6155432188
|
|
Thanks for the update @okmttdhr, I agree, let's get this in. |
okmttdhr
added a commit
to Automattic/jetpack
that referenced
this pull request
Sep 13, 2023
This was referenced Sep 13, 2023
bph
added
the
Needs Dev Note
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR makes the Back link on Block Theme Previews extensible with the settings store. Alternative to #54174.
Why?
Sometimes, 3rd party apps want to extend the Back link, as going back to /themes.php does not always make sense. c.f. Automattic/wp-calypso#80595
How?
The dashboard link is already customizable, but the theme preview path doesn't allow for the customization. This changes the way we modify the back link for the theme preview path so that it is also customizable.
Testing Instructions
You can also test that this is extensible by adding a plugin that modifies the editor settings:
Screenshots or screencast