Tweak border control button to proper metrics and simpler action #53998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Flaky tests detected in 544178b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6002642997
|
jasmussen
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Nice. I think in general we can improve reset buttons, and I'd love to just generally do a review of the color picker, although the color itself is a bit more legible, it's also fairly huge and a box within a box. Lots to do, but this is a good small step forward. Thankd!
|
Size Change: -17 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Sep 13, 2023
| @@ -1,6 +1,7 @@ | |||
| <!-- Learn how to maintain this file at https://github.com/WordPress/gutenberg/tree/HEAD/packages#maintaining-changelogs. --> | |||
|
|
|||
| ## Unreleased | |||
| - `BorderControl`: Apply proper metrics and simpler text ([#53998](https://github.com/WordPress/gutenberg/pull/53998)). | |||
There was a problem hiding this comment.
CHANGELOG entries should all go under a sub-section — ie. Enhancements, Bug fix, etc
We can tweak this in following PRs (eg. #54394)
ciampo
reviewed
Sep 13, 2023
| @@ -180,10 +180,10 @@ export const borderControlStylePicker = css` | |||
|
|
|||
| export const borderStyleButton = css` | |||
There was a problem hiding this comment.
Have you tried using the size="compact" prop on the Button component, instead of adding style overrrdes? That should render a 32x32 button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Minor fix to adjust the reset and style buttons to fit within the updated metrics (40px and 32px) buttons—as detailed in #46734. Also uses the correct border-top color now.
Testing Instructions
Screenshots or screencast