test: Automate mobile editor tests #53991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are covered by: `packages/block-library/src/social-links/test/edit.native.js`
Assert the fundamental functionality of setting a URL for a Social Link link.
dcalhoun
added
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.51 MB ℹ️ View Unchanged
|
dcalhoun
commented
Aug 28, 2023
There was a problem hiding this comment.
These test cases duplicate other tests.
| @@ -23,7 +23,7 @@ function LinkSettingsNavigation( props ) { | |||
| isVisible={ props.isVisible } | |||
| onClose={ props.onClose } | |||
| onDismiss={ props.onDismiss } | |||
| testID={ props.testID } | |||
| testID="link-settings-navigation" | |||
There was a problem hiding this comment.
I simplified this implementation as I did not believe a unique ID for each test case was notably beneficial.
dcalhoun
added a commit
to wordpress-mobile/test-cases
that referenced
this pull request
Aug 29, 2023
These tests were automated in the following: - WordPress/gutenberg#53991 - wordpress-mobile/gutenberg-mobile#6118
derekblank
pushed a commit
to wordpress-mobile/test-cases
that referenced
this pull request
Sep 5, 2023
These tests were automated in the following: - WordPress/gutenberg#53991 - wordpress-mobile/gutenberg-mobile#6118
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Automate testing core block functionality.
Why?
Reduce the likelihood of regressions.
How?
Testing Instructions
n/a
Testing Instructions for Keyboard
n/a
Screenshots or screencast
n/a