-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update typescript-eslint to v6 #53975
Conversation
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
Size Change: 0 B Total Size: 1.51 MB ℹ️ View Unchanged
|
I still need to test it locally but all the changes look good. There is a merging conflict in the changelog file that needs to be resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that npm run lint:js
continues to work locally.
Thanks @gziolo 👍 |
What?
Closes #52512
Update
@typescript-eslint/parser
,@typescript-eslint/eslint-plugin
andeslint-plugin-jest
dependencies in@wordpress/eslint-plugin
package.Why?
Unblocks projects that depend on latest version of
typescript-eslint
and@wordpress/eslint-plugin
.How?
@typescript-eslint/parser
and@typescript-eslint/eslint-plugin
.@typescript-eslint/no-duplicate-import
rule (see https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/no-duplicate-imports.md) withimport/no-duplicates
.eslint-plugin-jest
to latest version.eslint-plugin-jest
added v6 oftypescript-eslint
to their peerDependencies in 27.2.3.Testing Instructions
Run
npm run lint:js