Shortcut: Add Storybook stories #53627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Developer Documentation
mirka
reviewed
Aug 18, 2023
* Provide stories for the Shortcut component * Remove @example syntax for Storybook to parse JSDoc correctly Update packages/components/src/shortcut/stories/index.story.tsx Expand source tab by default in Storybook V7 Co-authored-by: Lena Morita <[email protected]> Cleanup ChangeLog
bangank36
force-pushed
the
story/shortcut-component
branch
from
3462b56
to
22a70c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
@examplesyntax on JSDoc for these components so Storybook can parse properly Update SelectControl JSDoc #53379 (comment)Why?
Missing stories for components has been discussed on #36128 (comment)
How?
@examplesyntax on the noted componentsTextcomponent: its stories and type migration should be addressed on followed-up PRsTesting Instructions
npm run storybook:dev?path=/docs/components-shortcut--docsis workingTesting Instructions for Keyboard
Screenshots or screencast