-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Reduce test output noise #53606
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The errors, warnings, and logs from these tests are expected for each test case. However, their presence creates noise the reduce the comprehensibility of the test output. Intentionally suppressing them simplifies the test output, making it easier to identify new, unexpected console output.
dcalhoun
added
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
labels
Aug 12, 2023
Size Change: 0 B Total Size: 1.5 MB ℹ️ View Unchanged
|
SiobhyB
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dcalhoun, LGTM, confirmed that these changes suppress the console output as expected. 👏 👏 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
[Type] Automated Testing
Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reduce native test output noise.
Why?
The errors, warnings, and logs from these tests are expected for each
test case. However, their presence creates noise and reduces the
comprehensibility of the test output. Intentionally suppressing them
simplifies the test output, making it easier to identify new, unexpected
console output.
How?
Intentionally suppress the console output for expected error, warnings, and
logs. This expected output is already monitored via assertions from
@wordpress/jest-import
.Testing Instructions
Note modified tests no longer produce console errors, warnings, or logs.
Example suppressed Block Invalid Warning test output
Example suppressed Embed test output
Testing Instructions for Keyboard
n/a
Screenshots or screencast
n/a