Patterns: fix color and behavior of unsynced patterns in block inserter when searching for reusable
#53205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Bug
|
Size Change: +46 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
92 tasks
aaronrobertshaw
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Thanks @glendaviesnz 👍
✅ Unsynced patterns in the inserter search results no longer have the synced block color
✅ Unsynced patterns are inserted as their parsed blocks
✅ Synced patterns continue to have the same color in the inserter search results
✅ Synced patterns are inserted as the pattern block
LGTM 🚢
aaronrobertshaw
added
the
Backport to WP 6.7 Beta/RC
tellthemachines
pushed a commit
that referenced
this pull request
Aug 1, 2023
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Makes sure unsynced patterns have an uncolored icon when displayed in inserter search results. Also make sure that they get inserted as an unsynced pattern when selected.
Why?
Currently they show as purple which confuses them with synced patterns.
How?
Checks the syncStatus of a pattern and don't assign color if
unsynced. Also, ifunsyncedinstert the parsed pattern content rather than the pattern block when selected.Testing Instructions
reusableand make sure the unsynced patterns display as black, and synced as purpleScreenshots or screencast
Before:
pattern-inserter-bug-before.mp4
After:
patterns-inserter-bug.mp4