Try text label instead of icon for "Detach" ToolbarButton #52998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
the
[Feature] Synced Patterns
|
Size Change: -172 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7b48e38. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5673630262
|
|
The before and after looks appealing enough. The main problem here is that the synced pattern title can be very long. What if its title was "Social links with a shared background color"? Do we elide the text? Point is, we can end up with very long titles, and if we combine that with a Detach label, we can just end up with a pretty long toolbar. Text-labels only mode is a bit of an example of what happens if we don't carefully approach block toolbar length, and at this point it needs a separate design iteration to become usable. |
|
I probably missed the memo but does this need to be a toolbar action? It doesn't seem like a common action... |
I don't think we really need it in the toolbar; as we have "Detach pattern" in the block options popover too. I can see us considering an "Edit" type flow in the toolbar, like template parts have (were you're bought into a focus view) — but detach in both places is a bit much. I can draw up a quick PR to remove it completely; thoughts? |
|
I'd be in favor of removing from the toolbar. As you said there's an affordance in the ellipsis menu which seems appropriately prominent given the frequency of this action. Additionally "Detach" – while better than the icon alone – is still a little ambiguous. This feels like an action that benefits from one or two extra words to clarify the behavior... there's space for that in the ellipsis, but probably not in the toolbar considering translations and the potential 'Edit' button. |
|
It can also be argued that given the Pattern changes, and how you can now create your own, the toggle between synced and unsynced really addresses the use case of "I want to insert this in a pre-detached state", making it perhaps a less common action to detach the synced one. |
I don't think you can insert a synced pattern detached right off? |
|
No no, I mean at that point it's a pattern. The point is, you can still create such an unsynced pattern, and edit it centrally. I'm referring to a use case I've seen where people had something they'd often insert in pages or posts as a starting point, saved as a reusable block that they'd insert and detach, to then edit. A hacky pattern alternative, so to speak. |
|
Based on feedback I spun up an alternative PR to remove the ToolbarButton altogether. Closing this in favor of #53121. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The unGroup icon, which is used for "Detach" in a synced pattern's toolbar, doesnt quite convey the notion of detaching an instance of a synced pattern. I wanted to try using a text label instead; if this control is necessary in the first place (as we have "Detach pattern" in the block options popover.
Testing Instructions
Screenshots or screencast