Update the ConfirmDialog that appears when applying a style revision over unsaved changes
#52972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
the
[Feature] Site Editor
|
Size Change: +696 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Jul 26, 2023
|
@ramonjd I think some tests may need updating here but I'm not sure how to do it. When you have a second could you please give instructions? :) |
I've updated the failing test for global styles. Basically it was looking for the old copy. 👍🏻 |
|
Good improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Simplify ConfirmDialog application in style revisions, and align with similar instances.
Why?
Consistency is good. A couple of principles are violated in this context:
How?
titleprop –ConfirmDialogdoesn't support it.confirmButtonTextnow repeats original action.Testing Instructions
Alignment
Examples of similar confirmation modals in the site editor:
We might consider the "Are you sure..." prefix an emerging principle, in which case the body copy might read:
cc @WordPress/gutenberg-design for thoughts on that.