Patterns: correctly color code unsynced patterns titles in site editor #52958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can be properly color coded
glendaviesnz
added
[Type] Bug
|
Size Change: +187 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Jul 26, 2023
packages/edit-site/src/components/header-edit-mode/document-actions/index.js
Outdated
Show resolved
Hide resolved
|
Thank you! This is working for me :) |
Co-authored-by: Andrew Serong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Makes sure the unsynced patterns do not have the purple title color in the site editor header bar.
Why?
Fixes: #52923
How?
Add an is-synced-entity class to document actions so synced entities can be properly identified and color coded.
Testing Instructions
In the site editor patterns section load a range of different patterns and template parts in the editor and check the color of the title and icon in the editor title bar are purple for synced patterns and black for unsynced patterns
Screenshots or screencast
Before:
After:
