-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List: allow ENTER on multi selection #52947
Conversation
Size Change: -19 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
Flaky tests detected in a44d9e5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5659561233
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! |
What?
Fixes point 2 of #48670. When you select two list items or more partially, pressing ENTER doesn't work. That's because it's not possible to replace the list items with a default block (paragraph), which is what the code is trying to insert.
Thinking about the issue more, we shouldn't be inserting a middle block at all. The caret should just appear in front of the second item. I tested this for paragraph as well in Apple notes and Google Docs, which is also not creating an empty middle item. Regardless, I think this new behaviour makes more sense, and it works for any sort of nested blocks.
Why?
How?
Testing Instructions
Select multiple list items partially and press Enter.
Testing Instructions for Keyboard
Screenshots or screencast