Global styles: update PHP unit tests #52819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removes tests that have been ported to Core already as part of WP 6.3 - Adds tests for #52370 - Changes a private method to protected so it can be used in inherited classes
ramonjd
added
[Type] Code Quality
12 tasks
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.4/class-gutenberg-rest-global-styles-controller-6-4.php ❔ lib/compat/wordpress-6.4/class-gutenberg-rest-global-styles-revisions-controller-6-4.php ❔ phpunit/class-gutenberg-rest-global-styles-revisions-controller-test.php |
cbravobernal
approved these changes
Jul 21, 2023
ramonjd
added a commit
to ramonjd/wordpress-develop
that referenced
this pull request
Sep 6, 2023
ramonjd
removed
the
Backport from WordPress Core
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Hello!
This PR:
Why?
Testing Instructions
Tests should pass:
npm run test:unit:php