Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Global styles: add text alignment section #52426

Closed
wants to merge 5 commits into from

Conversation

sejas
Copy link
Contributor

@sejas sejas commented Jul 7, 2023

WORK IN PROGRESS. For now, it's just a dummy UI with no real interaction.

What?

It adds text-alignment option to global styles.

Why?

Before adding justified text alignment at the block level, we will add the text alignment as a global style.
In this PR I suggest adding a text-alignment section to edit the text-alignment itself and hyphens on the global style.

How?

We are adding a new section to GlobalStylesUI.

Testing Instructions

  • On /wp-admin/ go to Appearance>Editor`
  • Click on Styles
  • Click on the pencil icon to edit styles
  • Observe the new section Text alignment is present below Typography
  • Click on it Text alignment
  • Observe the options Alignment and Hyphens are present. For now these options do nothing. It's still work in progress.

Testing Instructions for Keyboard

Screenshots or screencast

Screenshot 2023-07-07 at 14 55 09 Screenshot 2023-07-07 at 14 56 33

Screencast

global-text-alignment.mp4

Playground PR LIve preview

https://playground.wordpress.net/?gutenberg-pr=52426&url=/wp-admin/site-editor.php

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jul 7, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @sejas! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@hanneslsm hanneslsm mentioned this pull request Jul 12, 2023
@sejas sejas closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global Styles: Add alignment support in global typography styles
1 participant