Image block: Fix cursor style when lightbox is opened #52187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemiomorales
added
[Type] Bug
69 tasks
|
Size Change: -3 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 73e74ce. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5424928094
|
cbravobernal
approved these changes
Jun 30, 2023
cbravobernal
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The cursor to zoom out was not showing on the scrim when the lightbox was opened. Also, it was not showing when using the
fadeanimation at all. This fixes that style.Why?
Users should be signaled when using a mouse that clicking on any part of the lightbox overlay will close it.
How?
It puts the cursor style on the whole lightbox overlay rather than on just the image.
Testing Instructions
zoomandfadeanimation.Testing Instructions for Keyboard
N/A