Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social links: reverts updating class and style attributes #52019

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Social links: reverts updating class and style attributes #52019

merged 1 commit into from
Jun 29, 2023

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Jun 28, 2023

What

Reverts #51997

Why

As reported in #51997 (comment), get_block_wrapper_attributes already uses esc_attr on values passed to it.

Props to @swissspidy for catching it.

See: https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/class-wp-block-supports.php#L175

Testing instructions

Tests should pass
Social link block should render correctly on the frontend, with all classes/styles

@ramonjd ramonjd added [Type] Performance Related to performance efforts Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Jun 28, 2023
@ramonjd ramonjd self-assigned this Jun 28, 2023
@ramonjd ramonjd requested a review from ajitbohra as a code owner June 28, 2023 07:52
@ramonjd ramonjd added [Type] Bug An existing feature does not function as intended and removed [Type] Bug An existing feature does not function as intended labels Jun 28, 2023
@github-actions
Copy link

Flaky tests detected in 16282c0.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5398611015
📝 Reported issues:

carolinan
carolinan approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the block and the color settings manually without issues.

mukeshpanchal27
mukeshpanchal27 approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ramonjd, LGTM!

apeatling
apeatling approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@apeatling apeatling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All rendered correctly 👍

@ramonjd ramonjd merged commit 95c4948 into trunk Jun 29, 2023
@ramonjd ramonjd deleted the revert-51997-update/social-links-attributes branch June 29, 2023 00:28
@github-actions github-actions bot added this to the Gutenberg 16.2 milestone Jun 29, 2023
tellthemachines pushed a commit that referenced this pull request Jul 3, 2023
@ramonjd @tellthemachines
Revert "Updating social link attributes (#51997)" (#52019)
97e3acf 
This reverts commit c711e2a.
@tellthemachines
Copy link
Contributor

I just cherry-picked this PR to the update/wp6-3-beta3 branch to get it included in the next release: 97e3acf

@tellthemachines tellthemachines removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jul 3, 2023
tellthemachines added a commit that referenced this pull request Jul 3, 2023
@tellthemachines @ellatrix
@aaronrobertshaw @glendaviesnz @talldan @t-hamano @jameskoster @getdave @Mamaduka @scruffian @kevin940726 @carolinan @jasmussen @draganescu @jsnajdr @ramonjd @ntsekouras @SaxonF @richtabor @noisysocks
Update/wp6 3 beta3 (#52234)
6774683 
* Footnotes: inscrease selector specificity for anchor (#52179)

* Patterns: Include template parts for custom areas in Uncategorized category (#52159)

* Fix custom patterns console error (#51947)

* Fix error with react list key with new custom patterns list in inserter

* Update placeholder key

* Add comment to explain the different keys

* Patterns: Fix missing custom patterns in patterns explorer (#51889)

* Add custom patterns to pattern explorer

* show custom patterns in the patterns explorer dialog

* remove changes from 51877

* Fix up use of async lists

* remove a bit of code duplication by adding a new hook

* add 51877 fix back to make testing easier

* Just assign the key value in one place

* Refactor the custom patterns to use the usePatternsState hook

* Fix use of async list

* Translate strings and remove unneeded fields from pattern object

* Try integrating unsynced patterns directly into pattern selectors (#51955)

* Include reusable blocks with an undefined sync status in inserter items

* Update docs

* Remove change to hover dependencies

---------

Co-authored-by: Daniel Richards <[email protected]>

* i18n: Add context to the word "Filters" (#52198)

* Update home template icon (#52075)

* Centralise all permissions lookup in Link UI and enable (#52166)

* BlockRemovalWarningModal: Fix incorrect '_n' usage (#52164)

* Fix fetching Nav fallback ID flushing Navigation entity cache (#52069)

* Only flush the `getEntityRecords` cache if the fallback isn’t already in state

* Save the edited entity record to a const and then invert it to determine whether we should invalidate the recordds

---------

Co-authored-by: scruffian <[email protected]>

* Block Editor: Unify texts for Create pattern modal (#52151)

* Fix history back after entering edit mode from Patterns (#52112)

* Add template part icons to the library grid items (#51963)

* Patterns: Fix sidebar tab label (#51953)

* Patterns: Fix setting of sync status for fully synced patterns (#51952)

* Library: Reinstate manage all template parts page (#51961)

* Command Palette: fix incorrect path and snackbar message when template part is deleted (#52034)

* Command Center: Fix incorrect navigation when deleting template part

* removeTemplate: consider title type

* Drop-indicator: remove white border. (#52122)

* Make Navigation fallback selector private (#51413)

* Move selector to become private

* adds basic lock functionality

* remove useless lock-unlock file

* map private selectors to resolvers

* Unlock the other usage

* only create one fallback per session

* Fix core-data duplicate private opt-in

* Data: bind resolvers to selectors individually, support private selectors

---------

Co-authored-by: Andrei Draganescu <[email protected]>
Co-authored-by: scruffian <[email protected]>
Co-authored-by: Jarda Snajdr <[email protected]>

* Focus Mode: Use the symbol icon if a pattern is being edited (#52031)

* Footnotes: register meta field for pages (#52024)

* Fix unintentional toggling on of distraction free (#52090)

* replace toggle with set preference - because I don't read code properly it seems

* remove notification

* Revert "Updating social link attributes (#51997)" (#52019)

This reverts commit c711e2a.

* Update home template name (#52048)

* Removes unused call (#51988)

* Remove ability for user to toggle sync status after pattern creation (#51998)

* Fix disable DFM when opening styles command (#52165)

* Update custom patterns label to 'My patterns' (#51949)

* rename custom patterns to my patterns

* Add my patterns label to inserter and show at the top

---------

Co-authored-by: Daniel Richards <[email protected]>

* Library: Add sync status to pattern details screen (#51954)

* Patterns: Rename Library to Patterns (#52102)

* [Library] Add lock icon for theme patterns (#51990)

* Add lock icon for theme patterns

* Change to class names

* Add aria-description

* Change wording

* Patterns: Use "detached" copy consistently (#51993)

* Editor initrial appender: Zero out margins in constrained layouts. (#52026)

* Update pattern creation modal in library (#51946)

* Fix missing snackbars in Library (#52021)

* Make the entire preview clickable in order to enter "edit" mode in focus mode (#51973)

* Page Content Focus: Add welcome guides (#52014)

* Page Content Focus: Add welcome guides

* Don't show when editor guide is active

* Just use regular accent/theme color in all guides

* slight copy change page guide

* Update components changelog

* Disable new guides in E2E tests

* Use s.w.org videos

---------

Co-authored-by: Saxon Fletcher <[email protected]>

---------

Co-authored-by: Ella <[email protected]>
Co-authored-by: Aaron Robertshaw <[email protected]>
Co-authored-by: Glen Davies <[email protected]>
Co-authored-by: Daniel Richards <[email protected]>
Co-authored-by: Aki Hamano <[email protected]>
Co-authored-by: James Koster <[email protected]>
Co-authored-by: Dave Smith <[email protected]>
Co-authored-by: George Mamadashvili <[email protected]>
Co-authored-by: scruffian <[email protected]>
Co-authored-by: Kai Hao <[email protected]>
Co-authored-by: Carolina Nymark <[email protected]>
Co-authored-by: Joen A <[email protected]>
Co-authored-by: Andrei Draganescu <[email protected]>
Co-authored-by: Jarda Snajdr <[email protected]>
Co-authored-by: Andrei Draganescu <[email protected]>
Co-authored-by: Ramon <[email protected]>
Co-authored-by: Nik Tsekouras <[email protected]>
Co-authored-by: Saxon Fletcher <[email protected]>
Co-authored-by: Rich Tabor <[email protected]>
Co-authored-by: Robert Anderson <[email protected]>
sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
@ramonjd @sethrubenstein
Revert "Updating social link attributes (WordPress#51997)" (WordPress…
8ab45d1 
…#52019)

This reverts commit c711e2a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

@carolinan carolinan carolinan approved these changes

@apeatling apeatling apeatling approved these changes

@peterwilsoncc peterwilsoncc Awaiting requested review from peterwilsoncc

@swissspidy swissspidy Awaiting requested review from swissspidy

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@ramonjd ramonjd

Labels
[Type] Performance Related to performance efforts
Projects
No open projects
WordPress 6.3.x Editor Tasks
Status: ✅ Done
Milestone
Gutenberg 16.2
Development

Successfully merging this pull request may close these issues.
5 participants
@ramonjd @tellthemachines @apeatling @carolinan @mukeshpanchal27