-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Taxonomy as an option in the add template flow #51586
Remove Taxonomy as an option in the add template flow #51586
Conversation
Size Change: -2 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
Flaky tests detected in c2feb62. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5290753858
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
Nice. |
What?
Remove Taxonomy as an option in the add template modal
Why?
Some templates are technically complex and consequently excluded from the template creation UI, e.g.
singular
,$mimetype-$subtype
,$mimetype
, and$subtype
.I suspect that Taxonomy falls into this category, and we should consider removing it from the UI. To be clear: themes would still be able to create the template by adding the file, just as they can with
singular.html
etc.As a reminder, the Taxonomy template will display an archive of posts in any custom taxonomy when a more specific template cannot be found. Otherwise Archive, then Index, will be used.
It's a template you would generally only create when a custom taxonomy already exists, which is not the case on a vanilla WP installation. When a custom taxonomy does exist, and you want to create a template for it, the dedicated "Taxonomy Name" and "Taxonomy Name: Term" templates are much more intuitive. Just as it is more intuitive to use "Page" and "Single" templates instead of the ambiguous "Singular". Both of these options are already supported.
An added benefit of this change is that the add-template modal feels much less wordy by removing this one template.
How?
Remove
taxonomy
from array of support templates innew-template.js
.Testing Instructions