Search Block: Fix problem with buttons not outputting primary status #51529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Size Change: +1 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
skorasaurus
added
[Block] Search
apeatling
approved these changes
Jun 15, 2023
carolinan
approved these changes
Jun 16, 2023
|
Thanks for the review! |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes a problem where the width value matches the value of one of the buttons, but does not become the
primarystatus.Why?
This issue is very strange. As far as the code base is concerned, if the value set matches one of the buttons and the unit is a percentage, it should be
"primary".gutenberg/packages/block-library/src/search/edit.js
Lines 442 to 447 in 12a01d5
However, the actual value that the
Buttoncomponent receives in thevariantprop is the number zero.I am wondering why it is a numeric zero and not a
primarystring. At least as of #24666, when this feature was implemented, it appears that the primary state was correctly applied.As far as the built source is concerned, it is indeed replaced by zero. This may be due to an update to
babel.How?
After much trial and error, I found that comparing each variable individually, without comparing concatenated strings, correctly outputs the primary status.
Testing Instructions
When any button is pressed or a number or unit is changed, make sure that the corresponding button becomes the primary status.
Screenshots or screencast
d31453614a375b54978e8c90ed9d92eb.mp4