HTML-API: Backport updates from Core #51416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/compat/wordpress-6.3/html-api/class-wp-html-attribute-token.php
Outdated
Show resolved
Hide resolved
dmsnell
force-pushed
the
html-api/backport-updates-from-core
branch
from
735cbd4
to
eec2470
Compare
SergeyBiryukov
approved these changes
Jun 12, 2023
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
@hellofromtonya looks like we have another defect in the linting here, as it's blocking this PR, which is code already accepted and merged in Core. I'd like to merge this, but I don't like that we have a rejected CI stage. Seems like this happens almost every time we backport code from Core. Is someone working on addressing these problems? |
dmsnell
force-pushed
the
html-api/backport-updates-from-core
branch
3 times, most recently
from
270d4ea
to
410074f
Compare
This is a "blessed" PR, bringing back changes that were introduced to the HTML API in Trac/SVG that need to exist in Gutenberg to avoid introducing breakage and disharmony between the two repositories. cc: @SergeyBiryukov
dmsnell
force-pushed
the
html-api/backport-updates-from-core
branch
from
410074f
to
a40838d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a "blessed" PR, bringing back changes that were introduced to the HTML API in Trac/SVG that need to exist in Gutenberg to avoid introducing breakage and disharmony between the two repositories.
Notes
trunk. now thecompat/wordpress-6.2directory mirrors the HTML API as currently found in the6.2branch ofWordPress-developWordPress-develop/trunkonly the Tag Processor itself has been brought over, because the other files only involve docblock changes, not behavioral changes, and bringing them over also would require renaming everything inside the Tag Processor to use theGutenberg_..._6_3-wrapped versions of those classes.Why?
This is part of a normal process, whereby any updates to SVN need to be back-ported into Gutenberg.
How?
WordPress-develop/6.2copy all files intolib/compat/wordpress-6.2/html-api/WordPress-develop/trunkcopy just the tag processor intolib/compat/wordpress-6.3/html-apiGutenberg_..._6_3class name remains in the 6.3 compat layer instead of theWP_...name.Testing
Since these tests are already reviewed, tested, and merged into Core, they do not need additional review here. Please ensure that the test suite passes and that nothing was overlooked in the backport process, something which could lead to obvious and catastrophic breakage.
cc: @SergeyBiryukov (any changes in Trac/SVN need to have a corresponding PR here like this one, which incorporates the changes you applied).