Navigation: Don't interfere with pointer events #51378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -347 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
getdave
reviewed
Jun 9, 2023
There was a problem hiding this comment.
I tested this and I was able to replicate the bug on trunk and confirm it is fixed on this branch.
Nice work. I'd be broadly in favour of merging except that I'm a little confused about the purpose of the code we're removing.
Looks like it was modified by @noisysocks fairly recently. I wonder if he could shed some light on it?
Also @vcanales wrote the original code in #30047 so he might have ideas.
draganescu
approved these changes
Jun 22, 2023
I hated it and am glad to see it gone 😂 |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This CSS was messing with pointer events which made it possible to select a block that was behind the navigation overlay.
Why?
Users shouldn't be able to select blocks that are behind the navigation overlay when it is open.
How?
This code was messing around with the pointer events in the navigation block. Just deleting it seems to restore the behaviour we want and doesn't seem to cause any other issues.
Testing Instructions
Testing Instructions for Keyboard
Follow the steps above and confirm that the block can still be used with a keyboard.
Screenshots or screencast
See #51291