Update: Adjust modal radius to be between frame and buttons. #51254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
Size Change: -24 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
That seems fine to me..:) |
3 tasks
|
@ciampo do you know why the changelog test is failing here? |
ntsekouras
reviewed
Jun 16, 2023
packages/components/CHANGELOG.md
Outdated
| @@ -27,6 +27,7 @@ | |||
| - `ColorPalette`: Improve readability of color name and value, and improve rendering of partially transparent colors ([#50450](https://github.com/WordPress/gutenberg/pull/50450)). | |||
| - `Button`: Add `__next32pxSmallSize` prop to opt into the new 32px size when the `isSmall` prop is enabled ([#51012](https://github.com/WordPress/gutenberg/pull/51012)). | |||
| - `ItemGroup`: Update styles so all SVGs inherit color from their parent element ([#50819](https://github.com/WordPress/gutenberg/pull/50819)). | |||
| - `Modal`: Update corner radius to be between buttons and the site view frame, in a 2-4-8 system. ([#51254](https://github.com/WordPress/gutenberg/pull/51254)). | |||
There was a problem hiding this comment.
This should be placed under ## Unreleased section.
ntsekouras
approved these changes
Jun 16, 2023
jameskoster
approved these changes
Jun 16, 2023
|
Flaky tests detected in 15844a6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5288001439
|
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…ss#51254) * Update: Adjust modal radius to be between frame and buttons. * Update changelog. * Try moving changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Recently, the radius of all modals was changed from 2px to 8px. 2px for buttons, 8 for the larger frame.
This PR adjusts the radius of modals to 4px, which is between the two.
Why?
This harmonizes better with the 2px buttons that often sit inside confirm dialogs.
Testing Instructions
Test modals, such as ellipsis > keyboard shortcuts. Observe the smaller radius.