Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluid typography: extract logic to derive fluid typography settings #51188

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Fluid typography: extract logic to derive fluid typography settings #51188

merged 2 commits into from
Jun 6, 2023

Commits on Jun 6, 2023

  1. This commit updates the utilities to house logic to get the typograph… 

    …y settings.

Why is this required? Because there's a little tap dance that's needed to check whether fluid typography is enabled via boolean or object, and also whether a maximum viewport size value can be extracted from layout settings.
Adds tests as well.
    @ramonjd
    ramonjd committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    0727923 View commit details
    Browse the repository at this point in the history

  2. - rename typographySettings here to typographyOptions to indicate tha… 

    …t we're supposed to pass it the return value from getFluidTypographyOptionsFromSettings

- use TypographySettings as object return type
- test for null values in isFluidTypographyEnabled check
    @ramonjd
    ramonjd committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    33be494 View commit details
    Browse the repository at this point in the history