Term Description: Handle default margin styles #51137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikachan
added
the
[Block] Term Description
|
Size Change: +34 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 11c9b25. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5133608248
|
jffng
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Thanks @mikachan !
It's a bit unfortunate that this wrapper for the term description is necessary, because I think without it, we wouldn't need to add this CSS. But it looks like the wrapper is necessary to support text alignment.
Since it addresses the issue I'm giving the ✅ , also there is precedence for fixes like this.
|
This is great to see, given I had to do this just yesterday: wpengine/frost@48a6c0d |
artemiomorales
pushed a commit
to artemiomorales/gutenberg
that referenced
this pull request
Jun 2, 2023
|
Thank you, @mikachan ! |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #50515.
This PR attempts to zero out the paragraph margins on the Term Description block and apply the current block gap size as margins on the block wrapper. Currently, the block is using the default browser-inherited styles.
Why?
At the moment, the Term Description block is unstyled. By inheriting the user agent styles, there's no connection to the rest of the site.
How?
Added a stylesheet for the Term Description block that: zeros the default margins for the paragraph element, and applies the block gap size (
--wp--style--block-gap) to the Term Description wrapper.I added the block gap to the wrapper as otherwise there is no spacing around the Term Description block by default. By using the block gap variable, the size of this spacing is at least in line with the current theme.
Testing Instructions
Screenshots or screencast