Site editor: update untitled copy and rendering #51074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lues because decodeEntities will return an empty string if it encounters one. Updated Untitled copy to be consistent with pages view.
ramonjd
added
[Type] Bug
|
Size Change: -29 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
May 30, 2023
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…lues because decodeEntities will return an empty string if it encounters one. (WordPress#51074) Updated Untitled copy to be consistent with pages view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
"Untitled"to"(no title)"'||'to check for rendered titles run throughdecodeEntities()Why?
We can't perform nullish coalescing (??) checks on
decodeEntities()to verify falsy values becausedecodeEntities()will return an empty string if it encounters one.record.title?.renderedcontains an empty string.??returns the right-hand side operand if the left operand isnullorundefinedonly.Testing Instructions
wp-admin/site-editor.php) and select the "Pages""(no title)""(no title)"displaysScreenshots or screencast