Fix height mismatch between viewing and editing template parts #50775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
the
[Feature] Site Editor
ntsekouras
requested review from
youknowriad,
noisysocks,
talldan,
jameskoster and
ramonjd
|
Size Change: -22 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
|
This is how a "header" looks like in this PR. (in edit mode) 
In trunk, the height there is limited to the "content" of the template part and doesn't expand to the whole window. |
That's what I thought was wanted? Do we want the opposite? That means the template part to have the content height in 'view' mode? |
|
Yes, I think the opposite makes more sense. But @jasmussen might confirm here. |
|
My sense is that we want this:
That is, content-fitting height when previewing the frame, but full-height in the edit view. An alternative is content-fitting in both site view and edit view, though with built-in max-heights, but that might be weird in the edit view. @jameskoster just thought about this recently, he can add more. |
|
For me these views are about browsing/editing the template part alone, abstracted from any parent document. Kind of like viewing a component in Figma or Storybook. So what makes most sense to me is to display them as true-height in both site and edit views. This clearly communicates the global appearance and eliminates guesswork around margins. It would also be good (either here or in a follow-up) to reset any padding applied to 
The header above appears to be much larger than it is, due to the padding top / bottom on 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #48476
This PR just removes the specific height when editing a Template Part, so it defaults to
100%, like the rest of the frames' height. @youknowriad mentioned that there might be some nuances, but in my testing I didn't spot and side effect..Testing Instructions
editmode