Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site editor sidebar: add page details #50767

Merged
merged 12 commits into from
May 26, 2023
Merged

Site editor sidebar: add page details #50767

merged 12 commits into from
May 26, 2023

Commits on May 26, 2023

  1. setting the stage for page detail

    @SaxonF @ramonjd
    SaxonF authored and ramonjd committed May 26, 2023
    Configuration menu
    Copy the full SHA
    0e598d5 View commit details
    Browse the repository at this point in the history

  2. fix padding issues

    @SaxonF @ramonjd
    SaxonF authored and ramonjd committed May 26, 2023
    Configuration menu
    Copy the full SHA
    237a864 View commit details
    Browse the repository at this point in the history

  3. Filling in the details :)

    @ramonjd
    ramonjd committed May 26, 2023
    Configuration menu
    Copy the full SHA
    f38ff69 View commit details
    Browse the repository at this point in the history

  4. This commit: 

    - exports `getMediaDetails()` from the post-featured-image sidebar component and uses it if there's a featured image in the post record
- cleans up components and unused functions
- uses available wordcount and readtime functions
- implements i18n strings
- shuffles page-specific styles around
- update package log after importing @wordpress/wordcount
- truncating titles and other long excerpts
- adding status icons
- adding featured image description and loading placeholder
    @ramonjd
    ramonjd committed May 26, 2023
    Configuration menu
    Copy the full SHA
    b027db4 View commit details
    Browse the repository at this point in the history

  5. Adding SVG icons for status labels 

    Removing duped/unused test expectations
De-nesting BEM rules
Remove unused comments
i18n
    @ramonjd
    ramonjd committed May 26, 2023
    Configuration menu
    Copy the full SHA
    5eeb21a View commit details
    Browse the repository at this point in the history

  6. Removing duped/unused test expectations 

    De-nesting BEM rules
Remove unused comments
i18n
    @ramonjd
    ramonjd committed May 26, 2023
    Configuration menu
    Copy the full SHA
    e9d241c View commit details
    Browse the repository at this point in the history

  7. Displaying templates

    @ramonjd
    ramonjd committed May 26, 2023
    Configuration menu
    Copy the full SHA
    40e2825 View commit details
    Browse the repository at this point in the history

  8. We no longer need to pass down a className to SidebarNavigationScreen… 

    …. Reverting.
    @ramonjd
    ramonjd committed May 26, 2023
    Configuration menu
    Copy the full SHA
    929f2e6 View commit details
    Browse the repository at this point in the history

  9. style changes page detail site editor

    @SaxonF @ramonjd
    SaxonF authored and ramonjd committed May 26, 2023
    Configuration menu
    Copy the full SHA
    70bab25 View commit details
    Browse the repository at this point in the history

  10. Update colors

    @jameskoster @ramonjd
    jameskoster authored and ramonjd committed May 26, 2023
    Configuration menu
    Copy the full SHA
    c05d38b View commit details
    Browse the repository at this point in the history

  11. Ensuring that getFeaturedMediaDetails can be used locally. 

    Importing getFeaturedMediaDetails into privateApis for the editor package.
Removing unnecessary conditional checks
Escaping HTML and other values for rendering in page and attributes - adding escape-html to package.json
Don't render details when we don't have a record
    @ramonjd
    ramonjd committed May 26, 2023
    Configuration menu
    Copy the full SHA
    7287a73 View commit details
    Browse the repository at this point in the history

  12. Let's show password protected and private page status as well.

    @ramonjd
    ramonjd committed May 26, 2023
    Configuration menu
    Copy the full SHA
    8bbb116 View commit details
    Browse the repository at this point in the history