Tweak copy for block settings menu "Insert..." to "Add..." #50444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
|
Free flow of thoughts... Hmm the question to use insert og add. I kinda feels like a personal preference perhaps based on which language one was grown up with as well as other factors. So either we can change the places where "Insert" is being used to become "Add" or the opposite. Are we actually adding something or are we actually inserting something? |
|
Flaky tests detected in 8690b34. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4919121620
|
|
There is a touch of subjectivity, though I always lean towards consistency (changing this one case, vs. all the others). And "I'd like to add something to this page" seems more approachable/intuitive, rather than "I'd like to insert something on this page". |
jasmussen
approved these changes
May 9, 2023
|
Simpler and more consistent language across the board feels like a win to me. |
2 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Changes text string for "Insert before" and "Insert after" to "Add before" and "Add after" respectively. Brings these in line with the other cases referring to the addition of blocks to a page (see below).
Why?
In support of #49271, but also to add consistency across like labels/actions.
How?
Simple string change.
Testing Instructions
Screenshots or screencast
Other uses of "Add" for block addition: