Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography: remove duplicate comment #50304

Merged
merged 1 commit into from
May 4, 2023

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented May 4, 2023

What?

A comment in the typography block supports file was effectively doubled up. Let's get rid of it to avoid confusion.

Why?

Duplicate comments, oh what a bore,
Such clutter makes one's eyes quite sore.
Fear not though, for there's a way,
To sweep them clean and save the day.

With a click or two,
They vanish, to them: adieu.
The typography file now is neat,
And contributors' eyes can freely fleet.

So let us thank the tools we wield,
For keeping our pages un-congealed.
And let us strive to always be,
Duplication's arch enemy.

@ramonjd ramonjd self-assigned this May 4, 2023
@ramonjd ramonjd requested a review from spacedmonkey as a code owner May 4, 2023 03:11
Copy link
Contributor

@aaronrobertshaw aaronrobertshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@glendaviesnz
Copy link
Contributor

glendaviesnz commented May 4, 2023

I disagree 😄

In praise of duplication, let us sing,
For it's a boon that brings a wondrous thing.
A single rose, a solitary bloom,
Is lovely, yes, but fleeting is its doom.

Yet, with the art of doubling in our hand,
We multiply the beauty in the land.
A field of roses, mirrored row by row,
A sea of petals, where the breezes blow.

Consider, too, the words upon a page,
A single copy, locked within a cage.
But with duplication's clever art,
The words take flight, from mind to mind they dart.

A tale once told to just a single ear
Can echo wide, and travel far and near.
The poet's voice, the writer's ardent flame,
Are amplified, and spread abroad by name.

The scientist, with knowledge gained and stored,
Can share the wealth, and pass the learned hoard.
For duplication makes the findings known,
And seeds of wisdom far and wide are sown.

And what of love, that most elusive prize?
Can duplication make it multiply?
Perhaps it can, for love's a generous fire,
That kindles hearts and bids us to aspire.

So let us praise the art of making twain,
For in this act, there's much that we can gain.
In duplication, there is strength and grace,
A chance to share, and brighten every place.

@ramonjd ramonjd enabled auto-merge (squash) May 4, 2023 03:26
@ramonjd
Copy link
Member Author

ramonjd commented May 4, 2023

A single rose, a solitary bloom,
Is lovely, yes, but fleeting is its doom.

What beautiful but very bizarre imagery :trollface:

@ramonjd ramonjd merged commit be5cfd9 into trunk May 4, 2023
@ramonjd ramonjd deleted the update/remove-misleading-comment-typography branch May 4, 2023 03:48
@github-actions github-actions bot added this to the Gutenberg 15.8 milestone May 4, 2023
@bph bph added [Feature] Typography Font and typography-related issues and PRs [Type] Code Quality Issues or PRs that relate to code quality labels May 8, 2023
@ramonjd ramonjd added the Needs PHP backport Needs PHP backport to Core label Jun 5, 2023
@ramonjd ramonjd removed the Needs PHP backport Needs PHP backport to Core label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Typography Font and typography-related issues and PRs [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants