Save Hub: Reuse the save button component to save code #50145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alex Lende 5129775[email protected]
scruffian
force-pushed
the
use/save-button-in-save-hub
branch
from
29096c1
to
68ebfac
Compare
|
Size Change: -44 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
bph
added
[Package] Edit Site
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This refactors the SaveHub component to use the SaveButton component.
Why?
This means we can share code and reduce duplication.
How?
Pass the differences as props.
Testing Instructions
Check that the save button in the Site Editor in browse mode works the same as before:
Co-authored-by: Alex Lende [email protected]