Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global styles: close stylebook if the editor canvas container slot is not filled #50086

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Global styles: close stylebook if the editor canvas container slot is not filled #50086

merged 3 commits into from
Apr 27, 2023

Commits on Apr 26, 2023

  1. Alternative to #50081 which uses the original method of checking for … 

    …a slot fill to see if we need to render a custom header title for the editor canvas slot.
    @ramonjd
    ramonjd committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    0554029 View commit details
    Browse the repository at this point in the history

  2. Revert changes in #50081

    @ramonjd
    ramonjd committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    b151f86 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Reinstates trunk logic to check for global styles sidebar state AND t… 

    …hrows in a check for canvas mode === `edit`, both of which will affect whether we reset the editor canvas container.

If the global sidebar is closed or the canvas is no longer in edit mode, turn off the fills.
    @ramonjd
    ramonjd committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    ec51e51 View commit details
    Browse the repository at this point in the history