Add a few import required for the React Native wrapper distribution as iOS XCFramework #50009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, when using the experimental static linking which should hopefully enable us to wrap Gutenberg mobile in an XCFramework to import in iOS projects, we'd get a build failure with `WKUserScript` not found.
This allows the compiler to find the `RCTLogLevel` type used in the file.
This allows the compiler to find the `RCTEventEmitter` type which is used in the file.
geriux
approved these changes
May 3, 2023
|
@mokagio Let me know if you want me to merge it, not sure if you have rights to merge. Thanks! |
|
Thanks @geriux ! 🙌 Yes, I'd like this to be merged at your earliest convenience. Once it lands, it will allow me to stop pointing to a different submodule commit and use whatever is set in |
geriux
added
the
Mobile App - i.e. Android or iOS
|
Merged! By the way it looks like you have enough contributions merged to be able to request contributor access 🎉 you can find more info about it here, more specifically:
|
|
Thanks @geriux 🎉 |
bph
added
Mobile App - Release
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why? and How?
Adds a few imports in a few
react-native-bridge/ioscode. These are required for the setup to compile, as can be seen in wordpress-mobile/gutenberg-mobile#5695Testing Instructions
This PR should not affect the plugin behavior as it only touches files in the React Native brige package. As far as I understand the setup, green CI in the [
gutenberg-mobilePR using these changes]wordpress-mobile/gutenberg-mobile#5695) should be enough to establish correctness.Testing Instructions for Keyboard
N.A.
Ping @fluiddot @geriux can you help me get this reviewed and merged? I don't have the rights to ask for a review. Thanks!