Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR 49646: "[Font API] Use registered fonts for Block Editor iframe." #49863

Conversation

hellofromtonya
Copy link
Contributor

Reverts #49646

Removes this bug fix from trunk and 15.6 release, as it was included in 15.6 RC1.

Why?

Explained here

It needs to be bundled with the #40363 feature enhancement which (when implemented) will automatically enqueue all user selected fonts, selected from the Site Editor's Global Typography UI. Why? One of the most popular Google Fonts implementation has a bug in it where its fonts will not enqueue. The bug was hidden until this PR fixed the Fonts API for the iframe assets. Delaying the shipment of this PR's fix avoids breaking sites.

@hellofromtonya hellofromtonya added this to the Gutenberg 15.6 milestone Apr 17, 2023
@hellofromtonya hellofromtonya added the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Apr 17, 2023
@hellofromtonya hellofromtonya self-assigned this Apr 17, 2023
Copy link
Contributor

@anton-vlasenko anton-vlasenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this pull request, and it reverts all the code introduced in #49646. Therefore, it should be safe to merge this PR and I approve it.

@hellofromtonya hellofromtonya merged commit dc2e120 into trunk Apr 17, 2023
@hellofromtonya hellofromtonya deleted the revert-49646-fix/render-enqueued-fonts-block-editor-iframe branch April 17, 2023 14:18
bph pushed a commit that referenced this pull request Apr 17, 2023
@ndiego ndiego removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants