NavigableContailer: do not trap focus in TabbableContainer
#49846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -6 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Going to rebase to include changes from #49377 |
ciampo
force-pushed
the
fix/navigable-container-focus-trap
branch
from
97e70ec
to
9b05ffd
Compare
ciampo
added
[Type] Bug
chad1008
approved these changes
May 3, 2023
ciampo
force-pushed
the
fix/navigable-container-focus-trap
branch
from
4dff16e
to
a91f308
Compare
|
Flaky tests detected in a91f308. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4916239313
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While reviewing #49377, I noticed that
TabbableContinertraps focus within its boundaries even when thecycleprop isfalse.This PR tweaks the logic to fix the behavior and allow for the focus to leave
TabbaleContainerwhen thecycleprop is nottrueHow?
Moving the
preventDefaultcall only when the component is handling thefocusdirectlyTesting Instructions
Note that the
TabbableContainercomponent has currently no usages in the repository outside of its Storybook examples.Testing Instructions for Keyboard
On trunk:
TabbableContainerStorybook examplecycleprop is set tofalseOn this PR:
TabbableContainerwhen thecycleprop is set tofalse\Screenshots or screencast
trunk:tabbable-before.mp4
This PR:
Kapture.2023-04-27.at.15.42.24.mp4