Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial prototype of simplified layout panel #49459

Closed
wants to merge 13 commits into from

Conversation

tellthemachines
Copy link
Contributor

@tellthemachines tellthemachines commented Mar 30, 2023

What?

Starts moving towards the latest designs in #42385.

New layout panel controls vary depending on whether layout switching is allowed (such as for the Group block with its Row, Stack, and experimental Grid variations) or what the layout type is. E.g.:

Flex block:
Screenshot 2023-05-05 at 1 56 41 pm

Flow/constrained block:
Screenshot 2023-05-05 at 1 59 13 pm

Switchable block:
Screenshot 2023-05-05 at 1 57 08 pm

As it stands, these changes don't affect the layout API in any way, except for a small difference in behaviour for flex layouts: with vertical orientation, flex can now be switched to flow or constrained layout by toggling the content width control. This still causes a little weirdness in Buttons and Navigation blocks due to their custom styles and markup structures, but that can be fixed by updating the styles in those blocks.

Another side-effect of this PR is that the allowSwitching option now works very well, whereas on trunk it still looks somewhat broken.

Testing Instructions

  1. Add blocks with layout to a post or template, such as Group, Buttons, Social Icons, Navigation, Columns, Post Content.
  2. Try all the controls and check that everything behaves as expected.

Testing Instructions for Keyboard

Screenshots or screencast

@tellthemachines tellthemachines marked this pull request as draft March 30, 2023 03:47
@github-actions
Copy link

github-actions bot commented Mar 30, 2023

Size Change: +1.17 kB (0%)

Total Size: 1.44 MB

Filename Size Change
build/block-editor/index.min.js 211 kB +1.07 kB (+1%)
build/block-editor/style-rtl.css 14.9 kB +51 B (0%)
build/block-editor/style.css 14.9 kB +51 B (0%)
build/block-library/index.min.js 202 kB -3 B (0%)
ℹ️ View Unchanged
Filename Size
build/a11y/index.min.js 955 B
build/annotations/index.min.js 2.69 kB
build/api-fetch/index.min.js 2.28 kB
build/autop/index.min.js 2.1 kB
build/blob/index.min.js 451 B
build/block-directory/index.min.js 6.99 kB
build/block-directory/style-rtl.css 1.02 kB
build/block-directory/style.css 1.02 kB
build/block-editor/content-rtl.css 4.26 kB
build/block-editor/content.css 4.25 kB
build/block-editor/default-editor-styles-rtl.css 381 B
build/block-editor/default-editor-styles.css 381 B
build/block-library/blocks/archives/editor-rtl.css 61 B
build/block-library/blocks/archives/editor.css 60 B
build/block-library/blocks/archives/style-rtl.css 90 B
build/block-library/blocks/archives/style.css 90 B
build/block-library/blocks/audio/editor-rtl.css 150 B
build/block-library/blocks/audio/editor.css 150 B
build/block-library/blocks/audio/style-rtl.css 122 B
build/block-library/blocks/audio/style.css 122 B
build/block-library/blocks/audio/theme-rtl.css 126 B
build/block-library/blocks/audio/theme.css 126 B
build/block-library/blocks/avatar/editor-rtl.css 116 B
build/block-library/blocks/avatar/editor.css 116 B
build/block-library/blocks/avatar/style-rtl.css 104 B
build/block-library/blocks/avatar/style.css 104 B
build/block-library/blocks/block/editor-rtl.css 305 B
build/block-library/blocks/block/editor.css 305 B
build/block-library/blocks/button/editor-rtl.css 584 B
build/block-library/blocks/button/editor.css 582 B
build/block-library/blocks/button/style-rtl.css 624 B
build/block-library/blocks/button/style.css 623 B
build/block-library/blocks/buttons/editor-rtl.css 337 B
build/block-library/blocks/buttons/editor.css 337 B
build/block-library/blocks/buttons/style-rtl.css 332 B
build/block-library/blocks/buttons/style.css 332 B
build/block-library/blocks/calendar/style-rtl.css 239 B
build/block-library/blocks/calendar/style.css 239 B
build/block-library/blocks/categories/editor-rtl.css 113 B
build/block-library/blocks/categories/editor.css 112 B
build/block-library/blocks/categories/style-rtl.css 124 B
build/block-library/blocks/categories/style.css 124 B
build/block-library/blocks/code/editor-rtl.css 53 B
build/block-library/blocks/code/editor.css 53 B
build/block-library/blocks/code/style-rtl.css 121 B
build/block-library/blocks/code/style.css 121 B
build/block-library/blocks/code/theme-rtl.css 124 B
build/block-library/blocks/code/theme.css 124 B
build/block-library/blocks/columns/editor-rtl.css 108 B
build/block-library/blocks/columns/editor.css 108 B
build/block-library/blocks/columns/style-rtl.css 409 B
build/block-library/blocks/columns/style.css 409 B
build/block-library/blocks/comment-author-avatar/editor-rtl.css 125 B
build/block-library/blocks/comment-author-avatar/editor.css 125 B
build/block-library/blocks/comment-content/style-rtl.css 92 B
build/block-library/blocks/comment-content/style.css 92 B
build/block-library/blocks/comment-template/style-rtl.css 199 B
build/block-library/blocks/comment-template/style.css 198 B
build/block-library/blocks/comments-pagination-numbers/editor-rtl.css 123 B
build/block-library/blocks/comments-pagination-numbers/editor.css 121 B
build/block-library/blocks/comments-pagination/editor-rtl.css 222 B
build/block-library/blocks/comments-pagination/editor.css 209 B
build/block-library/blocks/comments-pagination/style-rtl.css 235 B
build/block-library/blocks/comments-pagination/style.css 231 B
build/block-library/blocks/comments-title/editor-rtl.css 75 B
build/block-library/blocks/comments-title/editor.css 75 B
build/block-library/blocks/comments/editor-rtl.css 840 B
build/block-library/blocks/comments/editor.css 839 B
build/block-library/blocks/comments/style-rtl.css 637 B
build/block-library/blocks/comments/style.css 636 B
build/block-library/blocks/cover/editor-rtl.css 647 B
build/block-library/blocks/cover/editor.css 650 B
build/block-library/blocks/cover/style-rtl.css 1.61 kB
build/block-library/blocks/cover/style.css 1.6 kB
build/block-library/blocks/details/editor-rtl.css 65 B
build/block-library/blocks/details/editor.css 65 B
build/block-library/blocks/details/style-rtl.css 178 B
build/block-library/blocks/details/style.css 178 B
build/block-library/blocks/embed/editor-rtl.css 293 B
build/block-library/blocks/embed/editor.css 293 B
build/block-library/blocks/embed/style-rtl.css 410 B
build/block-library/blocks/embed/style.css 410 B
build/block-library/blocks/embed/theme-rtl.css 126 B
build/block-library/blocks/embed/theme.css 126 B
build/block-library/blocks/file/editor-rtl.css 316 B
build/block-library/blocks/file/editor.css 316 B
build/block-library/blocks/file/style-rtl.css 269 B
build/block-library/blocks/file/style.css 270 B
build/block-library/blocks/file/view-interactivity.min.js 317 B
build/block-library/blocks/file/view.min.js 375 B
build/block-library/blocks/footnotes/style-rtl.css 201 B
build/block-library/blocks/footnotes/style.css 199 B
build/block-library/blocks/freeform/editor-rtl.css 2.58 kB
build/block-library/blocks/freeform/editor.css 2.58 kB
build/block-library/blocks/gallery/editor-rtl.css 947 B
build/block-library/blocks/gallery/editor.css 952 B
build/block-library/blocks/gallery/style-rtl.css 1.53 kB
build/block-library/blocks/gallery/style.css 1.53 kB
build/block-library/blocks/gallery/theme-rtl.css 108 B
build/block-library/blocks/gallery/theme.css 108 B
build/block-library/blocks/group/editor-rtl.css 654 B
build/block-library/blocks/group/editor.css 654 B
build/block-library/blocks/group/style-rtl.css 57 B
build/block-library/blocks/group/style.css 57 B
build/block-library/blocks/group/theme-rtl.css 78 B
build/block-library/blocks/group/theme.css 78 B
build/block-library/blocks/heading/style-rtl.css 76 B
build/block-library/blocks/heading/style.css 76 B
build/block-library/blocks/html/editor-rtl.css 336 B
build/block-library/blocks/html/editor.css 337 B
build/block-library/blocks/image/editor-rtl.css 834 B
build/block-library/blocks/image/editor.css 833 B
build/block-library/blocks/image/style-rtl.css 1.42 kB
build/block-library/blocks/image/style.css 1.42 kB
build/block-library/blocks/image/theme-rtl.css 126 B
build/block-library/blocks/image/theme.css 126 B
build/block-library/blocks/image/view-interactivity.min.js 1.46 kB
build/block-library/blocks/latest-comments/style-rtl.css 357 B
build/block-library/blocks/latest-comments/style.css 357 B
build/block-library/blocks/latest-posts/editor-rtl.css 213 B
build/block-library/blocks/latest-posts/editor.css 212 B
build/block-library/blocks/latest-posts/style-rtl.css 478 B
build/block-library/blocks/latest-posts/style.css 478 B
build/block-library/blocks/list/style-rtl.css 88 B
build/block-library/blocks/list/style.css 88 B
build/block-library/blocks/media-text/editor-rtl.css 266 B
build/block-library/blocks/media-text/editor.css 263 B
build/block-library/blocks/media-text/style-rtl.css 507 B
build/block-library/blocks/media-text/style.css 505 B
build/block-library/blocks/more/editor-rtl.css 431 B
build/block-library/blocks/more/editor.css 431 B
build/block-library/blocks/navigation-link/editor-rtl.css 712 B
build/block-library/blocks/navigation-link/editor.css 711 B
build/block-library/blocks/navigation-link/style-rtl.css 115 B
build/block-library/blocks/navigation-link/style.css 115 B
build/block-library/blocks/navigation-submenu/editor-rtl.css 296 B
build/block-library/blocks/navigation-submenu/editor.css 295 B
build/block-library/blocks/navigation/editor-rtl.css 2.26 kB
build/block-library/blocks/navigation/editor.css 2.26 kB
build/block-library/blocks/navigation/style-rtl.css 2.23 kB
build/block-library/blocks/navigation/style.css 2.22 kB
build/block-library/blocks/navigation/view-interactivity.min.js 988 B
build/block-library/blocks/navigation/view-modal.min.js 2.85 kB
build/block-library/blocks/navigation/view.min.js 469 B
build/block-library/blocks/nextpage/editor-rtl.css 395 B
build/block-library/blocks/nextpage/editor.css 395 B
build/block-library/blocks/page-list/editor-rtl.css 401 B
build/block-library/blocks/page-list/editor.css 401 B
build/block-library/blocks/page-list/style-rtl.css 175 B
build/block-library/blocks/page-list/style.css 175 B
build/block-library/blocks/paragraph/editor-rtl.css 174 B
build/block-library/blocks/paragraph/editor.css 174 B
build/block-library/blocks/paragraph/style-rtl.css 279 B
build/block-library/blocks/paragraph/style.css 281 B
build/block-library/blocks/post-author/style-rtl.css 175 B
build/block-library/blocks/post-author/style.css 176 B
build/block-library/blocks/post-comments-form/editor-rtl.css 96 B
build/block-library/blocks/post-comments-form/editor.css 96 B
build/block-library/blocks/post-comments-form/style-rtl.css 508 B
build/block-library/blocks/post-comments-form/style.css 508 B
build/block-library/blocks/post-date/style-rtl.css 61 B
build/block-library/blocks/post-date/style.css 61 B
build/block-library/blocks/post-excerpt/editor-rtl.css 71 B
build/block-library/blocks/post-excerpt/editor.css 71 B
build/block-library/blocks/post-excerpt/style-rtl.css 141 B
build/block-library/blocks/post-excerpt/style.css 141 B
build/block-library/blocks/post-featured-image/editor-rtl.css 588 B
build/block-library/blocks/post-featured-image/editor.css 586 B
build/block-library/blocks/post-featured-image/style-rtl.css 319 B
build/block-library/blocks/post-featured-image/style.css 319 B
build/block-library/blocks/post-navigation-link/style-rtl.css 153 B
build/block-library/blocks/post-navigation-link/style.css 153 B
build/block-library/blocks/post-template/editor-rtl.css 99 B
build/block-library/blocks/post-template/editor.css 98 B
build/block-library/blocks/post-template/style-rtl.css 314 B
build/block-library/blocks/post-template/style.css 314 B
build/block-library/blocks/post-terms/style-rtl.css 96 B
build/block-library/blocks/post-terms/style.css 96 B
build/block-library/blocks/post-time-to-read/style-rtl.css 69 B
build/block-library/blocks/post-time-to-read/style.css 69 B
build/block-library/blocks/post-title/style-rtl.css 100 B
build/block-library/blocks/post-title/style.css 100 B
build/block-library/blocks/preformatted/style-rtl.css 125 B
build/block-library/blocks/preformatted/style.css 125 B
build/block-library/blocks/pullquote/editor-rtl.css 135 B
build/block-library/blocks/pullquote/editor.css 135 B
build/block-library/blocks/pullquote/style-rtl.css 335 B
build/block-library/blocks/pullquote/style.css 335 B
build/block-library/blocks/pullquote/theme-rtl.css 167 B
build/block-library/blocks/pullquote/theme.css 167 B
build/block-library/blocks/query-pagination-numbers/editor-rtl.css 122 B
build/block-library/blocks/query-pagination-numbers/editor.css 121 B
build/block-library/blocks/query-pagination/editor-rtl.css 221 B
build/block-library/blocks/query-pagination/editor.css 211 B
build/block-library/blocks/query-pagination/style-rtl.css 302 B
build/block-library/blocks/query-pagination/style.css 299 B
build/block-library/blocks/query-title/style-rtl.css 63 B
build/block-library/blocks/query-title/style.css 63 B
build/block-library/blocks/query/editor-rtl.css 450 B
build/block-library/blocks/query/editor.css 449 B
build/block-library/blocks/quote/style-rtl.css 222 B
build/block-library/blocks/quote/style.css 222 B
build/block-library/blocks/quote/theme-rtl.css 223 B
build/block-library/blocks/quote/theme.css 226 B
build/block-library/blocks/read-more/style-rtl.css 132 B
build/block-library/blocks/read-more/style.css 132 B
build/block-library/blocks/rss/editor-rtl.css 149 B
build/block-library/blocks/rss/editor.css 149 B
build/block-library/blocks/rss/style-rtl.css 289 B
build/block-library/blocks/rss/style.css 288 B
build/block-library/blocks/search/editor-rtl.css 178 B
build/block-library/blocks/search/editor.css 178 B
build/block-library/blocks/search/style-rtl.css 587 B
build/block-library/blocks/search/style.css 584 B
build/block-library/blocks/search/theme-rtl.css 114 B
build/block-library/blocks/search/theme.css 114 B
build/block-library/blocks/search/view.min.js 631 B
build/block-library/blocks/separator/editor-rtl.css 146 B
build/block-library/blocks/separator/editor.css 146 B
build/block-library/blocks/separator/style-rtl.css 234 B
build/block-library/blocks/separator/style.css 234 B
build/block-library/blocks/separator/theme-rtl.css 194 B
build/block-library/blocks/separator/theme.css 194 B
build/block-library/blocks/shortcode/editor-rtl.css 323 B
build/block-library/blocks/shortcode/editor.css 323 B
build/block-library/blocks/site-logo/editor-rtl.css 754 B
build/block-library/blocks/site-logo/editor.css 754 B
build/block-library/blocks/site-logo/style-rtl.css 203 B
build/block-library/blocks/site-logo/style.css 203 B
build/block-library/blocks/site-tagline/editor-rtl.css 86 B
build/block-library/blocks/site-tagline/editor.css 86 B
build/block-library/blocks/site-title/editor-rtl.css 116 B
build/block-library/blocks/site-title/editor.css 116 B
build/block-library/blocks/site-title/style-rtl.css 57 B
build/block-library/blocks/site-title/style.css 57 B
build/block-library/blocks/social-link/editor-rtl.css 184 B
build/block-library/blocks/social-link/editor.css 184 B
build/block-library/blocks/social-links/editor-rtl.css 674 B
build/block-library/blocks/social-links/editor.css 673 B
build/block-library/blocks/social-links/style-rtl.css 1.44 kB
build/block-library/blocks/social-links/style.css 1.43 kB
build/block-library/blocks/spacer/editor-rtl.css 348 B
build/block-library/blocks/spacer/editor.css 348 B
build/block-library/blocks/spacer/style-rtl.css 48 B
build/block-library/blocks/spacer/style.css 48 B
build/block-library/blocks/table/editor-rtl.css 433 B
build/block-library/blocks/table/editor.css 433 B
build/block-library/blocks/table/style-rtl.css 645 B
build/block-library/blocks/table/style.css 644 B
build/block-library/blocks/table/theme-rtl.css 146 B
build/block-library/blocks/table/theme.css 146 B
build/block-library/blocks/tag-cloud/style-rtl.css 251 B
build/block-library/blocks/tag-cloud/style.css 253 B
build/block-library/blocks/template-part/editor-rtl.css 403 B
build/block-library/blocks/template-part/editor.css 403 B
build/block-library/blocks/template-part/theme-rtl.css 101 B
build/block-library/blocks/template-part/theme.css 101 B
build/block-library/blocks/term-description/style-rtl.css 111 B
build/block-library/blocks/term-description/style.css 111 B
build/block-library/blocks/text-columns/editor-rtl.css 95 B
build/block-library/blocks/text-columns/editor.css 95 B
build/block-library/blocks/text-columns/style-rtl.css 166 B
build/block-library/blocks/text-columns/style.css 166 B
build/block-library/blocks/verse/style-rtl.css 99 B
build/block-library/blocks/verse/style.css 99 B
build/block-library/blocks/video/editor-rtl.css 552 B
build/block-library/blocks/video/editor.css 555 B
build/block-library/blocks/video/style-rtl.css 185 B
build/block-library/blocks/video/style.css 185 B
build/block-library/blocks/video/theme-rtl.css 126 B
build/block-library/blocks/video/theme.css 126 B
build/block-library/classic-rtl.css 179 B
build/block-library/classic.css 179 B
build/block-library/common-rtl.css 1.1 kB
build/block-library/common.css 1.1 kB
build/block-library/editor-elements-rtl.css 75 B
build/block-library/editor-elements.css 75 B
build/block-library/editor-rtl.css 12.1 kB
build/block-library/editor.css 12.1 kB
build/block-library/elements-rtl.css 54 B
build/block-library/elements.css 54 B
build/block-library/reset-rtl.css 478 B
build/block-library/reset.css 478 B
build/block-library/style-rtl.css 13.7 kB
build/block-library/style.css 13.8 kB
build/block-library/theme-rtl.css 686 B
build/block-library/theme.css 691 B
build/block-serialization-default-parser/index.min.js 1.12 kB
build/block-serialization-spec-parser/index.min.js 2.87 kB
build/blocks/index.min.js 51 kB
build/commands/index.min.js 15.1 kB
build/commands/style-rtl.css 835 B
build/commands/style.css 834 B
build/components/index.min.js 241 kB
build/components/style-rtl.css 11.8 kB
build/components/style.css 11.8 kB
build/compose/index.min.js 12.1 kB
build/core-commands/index.min.js 2.44 kB
build/core-data/index.min.js 16.4 kB
build/customize-widgets/index.min.js 12 kB
build/customize-widgets/style-rtl.css 1.46 kB
build/customize-widgets/style.css 1.45 kB
build/data-controls/index.min.js 640 B
build/data/index.min.js 8.28 kB
build/date/index.min.js 17.8 kB
build/deprecated/index.min.js 451 B
build/dom-ready/index.min.js 324 B
build/dom/index.min.js 4.63 kB
build/edit-post/classic-rtl.css 544 B
build/edit-post/classic.css 545 B
build/edit-post/index.min.js 35.6 kB
build/edit-post/style-rtl.css 7.58 kB
build/edit-post/style.css 7.58 kB
build/edit-site/index.min.js 89.8 kB
build/edit-site/style-rtl.css 13.2 kB
build/edit-site/style.css 13.2 kB
build/edit-widgets/index.min.js 16.9 kB
build/edit-widgets/style-rtl.css 4.52 kB
build/edit-widgets/style.css 4.52 kB
build/editor/index.min.js 45.3 kB
build/editor/style-rtl.css 3.54 kB
build/editor/style.css 3.53 kB
build/element/index.min.js 4.8 kB
build/escape-html/index.min.js 537 B
build/format-library/index.min.js 7.59 kB
build/format-library/style-rtl.css 554 B
build/format-library/style.css 553 B
build/hooks/index.min.js 1.55 kB
build/html-entities/index.min.js 448 B
build/i18n/index.min.js 3.58 kB
build/interactivity/index.min.js 10.5 kB
build/is-shallow-equal/index.min.js 527 B
build/keyboard-shortcuts/index.min.js 1.64 kB
build/keycodes/index.min.js 1.84 kB
build/list-reusable-blocks/index.min.js 2.18 kB
build/list-reusable-blocks/style-rtl.css 836 B
build/list-reusable-blocks/style.css 836 B
build/media-utils/index.min.js 2.9 kB
build/notices/index.min.js 948 B
build/nux/index.min.js 1.99 kB
build/nux/style-rtl.css 735 B
build/nux/style.css 732 B
build/plugins/index.min.js 1.77 kB
build/preferences-persistence/index.min.js 1.84 kB
build/preferences/index.min.js 1.24 kB
build/primitives/index.min.js 943 B
build/priority-queue/index.min.js 1.52 kB
build/private-apis/index.min.js 951 B
build/react-i18n/index.min.js 615 B
build/react-refresh-entry/index.min.js 9.47 kB
build/react-refresh-runtime/index.min.js 7.31 kB
build/redux-routine/index.min.js 2.7 kB
build/reusable-blocks/index.min.js 2.71 kB
build/reusable-blocks/style-rtl.css 243 B
build/reusable-blocks/style.css 243 B
build/rich-text/index.min.js 11 kB
build/router/index.min.js 1.77 kB
build/server-side-render/index.min.js 1.94 kB
build/shortcode/index.min.js 1.39 kB
build/style-engine/index.min.js 1.83 kB
build/token-list/index.min.js 582 B
build/url/index.min.js 3.57 kB
build/vendors/inert-polyfill.min.js 2.48 kB
build/vendors/react-dom.min.js 41.8 kB
build/vendors/react.min.js 4.02 kB
build/viewport/index.min.js 958 B
build/warning/index.min.js 268 B
build/widgets/index.min.js 7.16 kB
build/widgets/style-rtl.css 1.15 kB
build/widgets/style.css 1.16 kB
build/wordcount/index.min.js 1.02 kB

compressed-size-action

@github-actions
Copy link

github-actions bot commented Mar 30, 2023

Flaky tests detected in 3148f00.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5733794594
📝 Reported issues:

@jasmussen
Copy link
Contributor

Thanks for working on this, and @SaxonF thanks for tirelessly pushing this forward. Getting the layout panel right is a big thing.

Giving some notes here, but I'm aware that this branch is not only billed only as an initial prototype, but is still in a draft state. So please take the feedback only as super high level conceptual stuff.

Here's layout as it works today:

before

Here's this branch:

after

A few notable differences:

  • New Layout Direction segmented control which chooses between the three flex options, stack, row, and the incoming Grid layout.
  • New Inner Block width, which presumably sets the width across every child block, just like how Gallery can set an image size across all child images.

While Saxon's mockup tell a more clear story, thinking in terms of how we move this forward, it's unclear to me what are the most compelling next steps. The Grid block is still experimental, so in the first versions, the segmented control would have only row and stack options, which more or less duplicate the behavior of the "Orientation" both in behavior and in terminology. Then there's the block transforms shortcuts at the top, between group, row and stack options, which jump somewhat awkwardly between the three. The layout direction also persists as "Stack", even when the Group option is selected.

Finally, I'm a bit unsure whether "inner block width" is actually a good idea. One of the strengths of flex items is that you can combine multiple different fit/fill/fixed widths together to create a complex layout, and presumably this dropdown would override all of them. It might be a handy shortcut for setting those values initially, but I wonder if the duplication won't ultimately make one or the other of the two controls — those on individual child blocks vs. the parent one — confusing.

It's definitely clear that layout needs to be simplified. But I'm wondering if this isn't actually adding a little complexity on the journey, rather than subtracting and combining?

@tellthemachines
Copy link
Contributor Author

Thanks for testing this @jasmussen !

I've updated to add the remaining controls, remove legacy controls and overall match Saxon's designs a bit better. I think it's now more or less working as expected but there may still be some rough edges. It should provide a better demo in any case!

@andrewserong
Copy link
Contributor

Very cool exploration! I found it a little confusing at first with the introduction of the Inner Block Width drop-down list. The switching between what we currently think of as Group and Stack seems quite subtle, whereas the difference in styling rules winds up being quite different. How will adjusting content / wide size work for these controls? From playing around with this PR, it sounds like the objective is to fold in the flow/vertical flex layouts a little within the UI so that the differences (from a user perspective) are more subtle. Elsewhere within the editor, though, we're currently highlighting Group, Row, and Stack as being quite separate. If they're more combined in the sidebar, does that mean we'd also be looking at revisiting how we highlight these layout / container blocks elsewhere?

I notice that this PR still has the different group block variations for selection within the placeholder state, but they appear to have been removed from the transform menu, and from multiple block selection. Was that intentional? It doesn't appear to be possible to transform to a Row block for example.

Here's how the panel's looking for me in testing:

image

But I'm wondering if this isn't actually adding a little complexity on the journey, rather than subtracting and combining?

I think that's my first impression, too. Overall it feels a little more complex to me, but I also wonder how much of that is that all the controls are exposed by default. Is it still the plan to switch the panel over to the ToolsPanel, and only have some controls displayed by default? Also, I think once the icons are added into the dropdowns as in the designs from #42385 (comment), that'll probably address some of the issues for me, personally. When it comes to adjusting alignments, I find the icons a little easier to work with for myself, though I know it's the other way around for lots of folks!

@@ -24,7 +24,7 @@ const variations = [
title: _x( 'Row', 'single horizontal line' ),
description: __( 'Arrange blocks horizontally.' ),
attributes: { layout: { type: 'flex', flexWrap: 'nowrap' } },
scope: [ 'block', 'inserter', 'transform' ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I think I see now. Is this removal to hide the transforms at the top of the sidebar? It also seems to hide the multiple block selection grouping buttons, as well as preventing blocks from being transformed to the different variations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wanted to disable the top of sidebar transforms specifically. Is there any way to disable them without those side-effects?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is at the moment, but it looks like the logic is currently to grab the variations based on transform here: https://github.com/WordPress/gutenberg/blob/trunk/packages/block-editor/src/components/block-variation-transforms/index.js#L112 — so if we want to conditionally hide it for a particular block, we might need an update somewhere around that file? I'm not sure how it'd ideally be flagged in the variations, but hope that helps!

@tellthemachines
Copy link
Contributor Author

Is it still the plan to switch the panel over to the ToolsPanel, and only have some controls displayed by default?

I think not, but controls may display or not depending on what layout type is selected. E.g. wrap control should only display for Row, and custom content size controls only display if the inner width is set to "custom" (I might have forgotten to add those in last week 😅 )

My main question is what might this look like for blocks that have only one layout type enabled, e.g. Buttons or Social Icons that only allow flex. Currently on this branch it's a free for all, but we'd probably want to lock things down a bit so blocks can be configured to have only one layout type.

@andrewserong
Copy link
Contributor

I think not, but controls may display or not depending on what layout type is selected.

Ah, gotcha. From the designs, it looks like there's still the ellipsis button at the top right, so I'd assumed the ToolsPanel would be used, at least to be able to reset individual controls?

My main question is what might this look like for blocks that have only one layout type enabled, e.g. Buttons or Social Icons that only allow flex.

For individual blocks, would they still be able to define which controls to be used (or hidden) in block.json?

but we'd probably want to lock things down a bit so blocks can be configured to have only one layout type.

Sounds good 👍

@tellthemachines
Copy link
Contributor Author

I've been playing around with this a bit, because in the current state of this branch the layout controls allow for switching any block to any layout type. While the experience could be worse, there are a few cases in which block-specific styles or the nature of the block content give rise to some awkward results:

Navigation block with a grid layout, squished into a small space:
Screenshot 2023-05-04 at 11 51 53 am
(not sure if we should do anything about blocks wider than the grid size breaking out of their container or not. Also note the block inserter button is happily taking up the full width of its container.)

Buttons with constrained/flow layout:
Screenshot 2023-05-04 at 11 54 19 am
(Button has a default inline-block style, and 0 margin.)

Social Icons with constrained layout:
Screenshot 2023-05-04 at 11 56 57 am

Post Content with grid layout:
Screenshot 2023-05-04 at 11 58 11 am

@tellthemachines tellthemachines added Needs Design Feedback Needs general design feedback. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Layout Layout block support, its UI controls, and style output. labels May 4, 2023
@tellthemachines
Copy link
Contributor Author

Ok folks I've updated the PR to support showing only controls for specific layout types, which fixes most of the issues above. I think this is now in a pretty good place, plus it works as a POC that we can make these UI changes without altering the layout API in any way (so this PR won't stand in the way of API stabilisation).

Which means this is now ready for some more feedback!

@jasmussen
Copy link
Contributor

Took this for a spin:

simplified layout

As a proof of concept, it's succeeding for me in two ways:

  • Demonstrating the value of approaching the layout panel, and even the layout types and container variants, as a single interface with unified tools across.
  • It is starting to suggest that we might need a compact version not just of buttons, but of things like segmented controls as well. Right now the vertical and horizontal are kinda crammed in there, and they should feel more like they are resting, and be able to have a full 16px gap between them. Yet I still agree, those two controls need to be on one row.

There are still a couple of details to work out:

  • I'm not sure the inputless gap slider is that useful, in terms of how it differentiates from other sliders (like min. column width on grid). I'd also keep calling it Block spacing, or spacing.
  • Either the icons for content width need to be a bit clearer and feel more at home, or the Fit/Fill/Fixed terminology works better for me.
  • It seems valuable to refine the description of the Grid type, so that the inspector doesn't layout-shift when toggling to it.

Exciting work!

@annezazu
Copy link
Contributor

annezazu commented May 8, 2023

Noting that I'm keeping an eye on this PR and would love to put it through a round of testing with the FSE Outreach Program. Please let me know when we're at that point (I'll also do my best to stay on top of where this goes).

@beafialho
Copy link

Very cool. I tinkered with this a bit and here are some first reactions:

  • Generally it seems to works well. The way the controls are presented is simpler than the current solution, while it offers more options.
  • Grid is quite nice and I think it would be really useful, especially if we could control Query Loop this way!
  • Content width confuses me a bit, especially the "Fit" and "Fill" where I can't quite tell the difference. Another point of confusion is that I still see the "Wide" and "Full" width controls, which seems redundant, even though I see it does not do the same thing:
Captura de ecrã 2023-05-09, às 14 59 46

Here's a situation where I'm clicking the three different options and it seems to change height, not width:

layout.mp4

Nonetheless, this is exciting!

@tellthemachines
Copy link
Contributor Author

Grid is quite nice and I think it would be really useful, especially if we could control Query Loop this way!

We're trying to move Post Template to a grid layout in #49050, although currently it's behaving exactly as on trunk in terms of the grid's responsiveness. What grid features do you think would be good to have in there?

Here's a situation where I'm clicking the three different options and it seems to change height, not width:

Ah, that's an interesting one. Initially you have a vertical flex layout with vertical space between, so the last child is pushed all the way down to the bottom. When you select "theme" content width, the layout changes to constrained, which doesn't support vertical space between, so the last child jumps back to the top. Same with "fill", where the layout is switched to flow.

Incidentally, that exposes a limitation with this branch that we don't have on trunk: by making "fill" always switch to flow layout, it's now impossible to have a vertically spaced between Stack with horizontally stretched items. I'm not sure how much of an issue that might be for folks creating layouts with combinations of Row and Stack blocks.

@richtabor
Copy link
Member

Content width confuses me a bit, especially the "Fit" and "Fill" where I can't quite tell the difference. Another point of confusion is that I still see the "Wide" and "Full" width controls, which seems redundant, even though I see it does not do the same thing:

Yea, this causes friction all the time. Basically, if set to "Fill" you shouldn't have wide/fullwidth options for nested blocks, as they "fill" the container space.

@tellthemachines tellthemachines added the [Type] Feature New feature to highlight in changelogs. label Aug 2, 2023
@mtias
Copy link
Member

mtias commented Aug 2, 2023

I'm not sure this is an improvement over the current variation toggles at the top of the block inspector, which are reinforced by the icons in the multi-select transforms, etc:

image

@tellthemachines
Copy link
Contributor Author

Closing this one in favour of #53455.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Layout Layout block support, its UI controls, and style output. Needs Design Feedback Needs general design feedback. [Type] Feature New feature to highlight in changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants